Fix lib exclude #37
Closed
Fix lib exclude #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the new react-transform for hot-reloading: https://github.com/gaearon/babel-plugin-react-transform Note, transform does nothing when `process.env.NODE_ENV` is set to `’production’`. - removes react-hot-loader - moves es stage settings to .babelrc - adds react-transform settings to .babelrc
makes errors very nice to deal with, shows a red error container over your app window, much like React native. https://github.com/gaearon/react-transform-catch-errors https://github.com/KeywordBrain/redbox-react
any folders inside of app called lib will not be compiled with babel. adds node_modules exclude to css to prevent slow-down.
|
This won't work, the core-js custom build script needs to be updated to reflect the new lib folder path. I can just make this change myself |
Oh just an FYI, in this PR the lib path is the same as now. It's from my prod app so I know the core-js works. However if you wanted to tuck that away in webpack/lib I think that would be better. |
|
Oh, sorry, I already pushed the change that moves lib into the webpack folder. |
|
Cool, I think that's for the better 👍 Cleaner and out of sight 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the last of my lib issues. I had a component lib folder that had mixins for that component and I happened to name it
lib/. This only ignores the lib in the root folder.However, perhaps a better fix is to move
./libintowebpack/lib/*since it's used specifically for webpack builds. This would allow an easier path to ignore and move it out of the root.