Update regex to allow for new sha-ish ids in Gist. #1
Conversation
Recently Gist unified all the URLs (which in public gists were numeric and in private gists, alphanumeric). This made certain flows break but Gist now should redirect to the proper url if given either the new SHA-ish id or the classic numeric ID.
|
Hey @leongersing! I was going to ask for documentation of the new sha-ish stuff, but it looks like you might be a bit more trustworthy than the average GitHub user. 😉 I ran the tests locally (weird that Travis wasn't turned on...) and it all looks good to me! Will release jekyll-gist 1.1.0 momentarily. Thank you for the PR! |
|
thanks @parkr! (Ithaca? I went to Ithaca College back in the 90s! I love that gorges town 😉) PR was my pleasure and If I can be of any further service, just holler to me. 😄 🎆 🤘 |
whaaaaaaa??? Currently sitting in CTB, soaking up the Ithaca summer sun. So awesome to meet someone else on GitHub who's studied here! I just graduated from Cornell. 😃
You da 💣 dot com, man. Thanks, will do! |
Recently Gist unified all the URLs (which in public gists were numeric
and in private gists, alphanumeric). This made certain flows break but
Gist now should redirect to the proper url if given either the new
SHA-ish id or the classic numeric ID.
This PR also resets some of the assumptions in the test suite to better
match the current implementation of Gist.