Skip to content

ES6 template strings are not being highlighted #59

Open
@mmwtsn

Description

@mmwtsn

This is what I'm seeing:

strings

I've tried this with a handful of themes using version c907b15. Is anyone else seeing highlighted template strings? It looks like this feature was added in #51.

Activity

changed the title [-]ES6 template strings are not working[/-] [+]ES6 template strings are not being highlighted[/+] on Sep 13, 2015
averted

averted commented on Sep 13, 2015

@averted
Contributor

Yep, this is working fine for me:
screen shot 2015-09-12 at 8 19 58 pm

You have to alter your colorscheme for it to pick up javaScriptTemplate* ids introduced in #51:
screen shot 2015-09-12 at 8 37 40 pm

This is a custom scheme I'm using so it will be different for you, but you get the idea.

jlipps

jlipps commented on Sep 14, 2015

@jlipps

just submitted a patch for tomorrow-night in case anyone is using that: chriskempson/vim-tomorrow-theme#44

mmwtsn

mmwtsn commented on Sep 14, 2015

@mmwtsn
ContributorAuthor

Ah, interesting. Thanks for explaining that.

Rather than patching all of our themes why not highlight javaScriptTemplateString inside this repo? I added a line here to highlight template strings with String and it's working nicely.

Would be happy to open a pull request if that approach makes sense.

sirbrillig

sirbrillig commented on Dec 29, 2015

@sirbrillig

If it's helpful for anyone else who ends up here, adding this to your vimrc should take care of the highlighting for most themes: https://gist.github.com/sirbrillig/fc0630baf46a2c10667f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jlipps@mmwtsn@sirbrillig@averted

        Issue actions

          ES6 template strings are not being highlighted · Issue #59 · jelera/vim-javascript-syntax