Impossible to fetch artifact for the build that is no longer in queue

[wtrocki]

Queue items are removed after build is finished. Current api allows only to fetch artifact for the queue item which makes this solution extremely inflexible.

To fetch artifact any time after build new api method should be introduced that would allow to specify build number and job name as input.

[khmarbaise]

Maybe I misunderstand your request but what about:

JenkinsServer js = new JenkinsServer(URI.create("http://jenkins/"));
JobWithDetails job = js.getJob("test-results");
Build buildByNumber = job.getBuildByNumber(1);

or what about:

JenkinsServer js = new JenkinsServer(URI.create("http://jenkins/"));
JobWithDetails job = js.getJob("test-results");

List<Build> builds = job.getBuilds();
List<Build> allBuilds = job.getAllBuilds();
List<Build> buildRanges = job.getAllBuilds(Range.build().from(5).to(10));

[wtrocki]

Yes. That's the workaround I'm using at the moment, but in the background it would make two requests. Feel free to close this issue.

[khmarbaise]

If you take a look into the code you will see that only getJob(..) will make a REST API call whereas getBuildByNumber(..) will not do so.

If you use getAllBuilds()... or getAllBuilds(Range...) than a supplemental call will be done...

[wtrocki]

Yes, but that object is not useful. In real word scenario you always fetching BuildWithDetails to get information about artifacts etc. Fix in PR is really simple and it would make API much cleaner. It may break existing object oriented concept.

[khmarbaise]

It sounds like I misunderstand what you have written...

Build buildByNumber = job.getBuildByNumber(1);

If you have Build you can fetch the needed information via

BuildWithDetails details = buildByNumber.details()

BTW: Can you give a code example of what you like to do or what you are doing ? So I get a better impression of what we are talking about?

[wtrocki]

Sorry for confusion. I think we are ok with this one additional call.
That's our current implementation:
https://github.com/aerogear/digger-java/blob/master/src/main/java/org/aerogear/digger/services/ArtifactsService.java#L73-L79

After merging this PR #214 we can just:

BuildWithDetails build = client.getBuild("test",1);

I think that approach not aligned with the way this client is build and we can close this issue.
In our client we just trying to implement some high level operations that can be achieved in simple call. This library is fairly generic and it would be better to keep it that way instead adding new methods to top level client object like client.getArtifact or client.getLogs
Sorry for confusion.

[khmarbaise]

You can of course use something like this: js.getJob("non-maven-test").getBuildByNumber(1).details();? Or do you think it's more convenient to have supplemental methods with parameters you have suggested?