fixes #339 by adding appropriate getters #346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 2, 2018 13:36
… getJobXmlShouldReturnTheExpectedConfigXml()
…etJenkinsServer()
…ConfigXml() as I just cant get it to match ...
khmarbaise
reviewed
Sep 13, 2018
| @@ -36,7 +36,7 @@ after_script: | |||
| # http://www.webupd8.org/2017/06/why-oracle-java-7-and-6-installers-no.html | |||
| # - oraclejdk8 is not supported anymore. | |||
| jdk: | |||
| - openjdk7 | |||
| - openjdk8 | |||
| cache: | |||
There was a problem hiding this comment.
Can we have a separate PR for upgrading Java version? This needs also to be made clear in ReleaseNotes ...
There was a problem hiding this comment.
The change to maven-compiler-plugin should be part of the PR...
There was a problem hiding this comment.
I created #358 and a PR for this topic.
Could we maybe have a chat/call to discuss a more general topic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.