Implement a high performance paginator #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremykenedy
approved these changes
Oct 3, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with millions activity records, the default behavior to not paginate records or Laravel's paginator (enabled by
LARAVEL_LOGGER_PAGINATION_ENABLED=true) may lead to huge performance penalties.For that use case, this PR implements
LARAVEL_LOGGER_CURSOR_PAGINATION_ENABLED=trueto enable Laravel's Cursor Pagination feature. This heavily improves Laravel Logger page loading time.When enabled, it's advisable to read Cursor vs. Offset Pagination section on Laravel's documentation to get acquainted with Cursor Pagination limitations.