Add API documentation for create string from a valid UTF8 string functions. #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
force-pushed
the
api_utf8_documentation
branch
from
49facac to
c29006e
Compare
zherczeg
reviewed
Nov 22, 2016
|
|
||
| Create string from a valid UTF8 string. | ||
|
|
||
| *Note*: It differs from [jerry_create_string](#jerry_create_string) function in this converts all 4-bytes long unicode sequences into two 3-bytes long sequences. |
There was a problem hiding this comment.
The difference from ... is that it accepts utf-8 string instead of cesu-8 string.
zherczeg
reviewed
Nov 22, 2016
| @@ -339,6 +339,13 @@ main (void) | |||
| TEST_ASSERT (sz == 0); | |||
| jerry_release_value (args[0]); | |||
|
|
|||
| // Test create_jerry_string_from_utf8 with 4-byte long unicode sequences | |||
| args[0] = jerry_create_string_from_utf8 ((jerry_char_t *) "𝔡𝔢𝔣𝔤"); | |||
There was a problem hiding this comment.
I would prefer for using \x.. byte sequence instead of real characters (since you don't know the character code of these characters). A four byte long sequence should be part of it as well.
robertsipka
force-pushed
the
api_utf8_documentation
branch
from
c29006e to
1d2bd8a
Compare
…ate_string_sz_from_utf8 functions. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]
robertsipka
force-pushed
the
api_utf8_documentation
branch
from
1d2bd8a to
b4bb2ef
Compare
|
Thanks, I've updated this patch. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.