-
Notifications
You must be signed in to change notification settings - Fork 683
add arraybuffer test file #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add arraybuffer test file #1477
Conversation
c8beb34
to
fce623d
Compare
* limitations under the License. | ||
*/ | ||
|
||
var a = new ArrayBuffer(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space after ArrayBuffer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zherczeg There's actually no space needed after ArrayBuffer. Doing a quick "find -name '*.js'|xargs cat|grep new" in jerry-test-suite shows that there is not a single constructor invocation where there is a space before the parentheses.
This patch looks quite good. Please fix the style issues first. |
0b1b536
to
29c63a7
Compare
Please update the commit message. Add the related issue number to it. Ex.: "Fixes #1475" |
@tilmannOSG hm, you are rgiht. Example 08.01-001.js:
There is a space after typeof, but there is no space after assert. This is kind of a mixed style, but it is not a good practice. What shall we do? Let people use whatever they want? These are tests, so perhaps this way we would cover a bigger range of issues. |
29c63a7
to
59a525b
Compare
fix issue jerryscript-project#1475 JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang [email protected]
@zherczeg I think for now people should just follow whichever style is the most common, e.g. in this case keep the space after the typeof. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat all function/constructor calls to not include a space before the opening parenthesis (this is the formatting used for all the JavaScript source files in JerryScript right now).
* limitations under the License. | ||
*/ | ||
|
||
var a = new ArrayBuffer (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No space between ArrayBuffer and the parentheses please (as discussed previously, seems GitHub lost that feedback).
*/ | ||
|
||
var a = new ArrayBuffer (); | ||
assert (typeof a === 'object'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: No space between assert and the opening parenthesis please.
59a525b
to
20b5111
Compare
fix issue jerryscript-project#1475 JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang [email protected]
#1475
add test files for ArrayBuffer builtin object #1467
JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang [email protected]