Skip to content

self-help (Open Sourcing Backpack) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Oct 16, 2018
Merged

self-help (Open Sourcing Backpack) #21

merged 41 commits into from
Oct 16, 2018

Conversation

axrs
Copy link
Contributor

@axrs axrs commented Oct 6, 2018

Preparation for Open Sourcing this project:

Then setup github pages at https://github.com/jesims/backpack/settings to serve docs/ on master

@axrs axrs changed the title self-help self-help (Open Sourcing Backpack) Oct 6, 2018
backpack.sh Outdated
desc+="\n\t\t$line"
fi
done <<< "$doc"
echo -e "SYNOPSIS$synopsis\n\nDESCRIPTION$desc"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self documenting bash usage based on comments used above functions

Copy link
Contributor

@AndreTheHunter AndreTheHunter Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

axrs added 2 commits October 6, 2018 14:07
added license
Remove Build Scripts
Update parent
Change wording
Update readme in preparation
@axrs
Copy link
Contributor Author

axrs commented Oct 9, 2018

Note: Like specs, the package.json is commited to allow Shadow-cljs to read the dependencies

lein deploy clojars
abort_on_error
fi
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still logged password with LEIN_SILENT=true technomancy/leiningen#1675

LEIN_SILENT suppressed some messages, but not the deploying ones

With silent (Compiling message is missing, so it was working...)

[backpack.sh] snapshot: Snapshotting 0.0.17-SNAPSHOT
Leiningen's classpath: :/usr/share/java/leiningen-2.8.1-standalone.jar
Applying task deploy to [clojars]
Applying task javac to nil
Running javac with [@/tmp/.leiningen-cmdline2961096293695065364.tmp]
Applying task compile to nil
Deploying {[:extension jar] /root/project/target/backpack-0.0.17-SNAPSHOT.jar, [:extension pom] /root/project/pom.xml} to [clojars {:url https://clojars.org/repo, :password REDACTED, :username REDACTED, :sign-releases false}]
Retrieving io/jesi/backpack/0.0.17-SNAPSHOT/maven-metadata.xml 
    from https://clojars.org/repo/
Sending io/jesi/backpack/0.0.17-SNAPSHOT/backpack-0.0.17-20181009.111454-4.jar (37k)
    to https://clojars.org/repo/
Sending io/jesi/backpack/0.0.17-SNAPSHOT/backpack-0.0.17-20181009.111454-4.pom (6k)
    to https://clojars.org/repo/
Retrieving io/jesi/backpack/maven-metadata.xml from https://clojars.org/repo/
Sending io/jesi/backpack/0.0.17-SNAPSHOT/maven-metadata.xml (1k)
    to https://clojars.org/repo/
Sending io/jesi/backpack/maven-metadata.xml (1k)to https://clojars.org/repo/

Without Silent

[backpack.sh] snapshot: Snapshotting 0.0.17-SNAPSHOT
Leiningen's classpath: :/usr/share/java/leiningen-2.8.1-standalone.jar
Applying task deploy to [clojars]
Applying task javac to nil
Running javac with [@/tmp/.leiningen-cmdline8996574156296288412.tmp]
Applying task compile to nil
Compiling io.jesi.backpack.random
Created /root/project/target/backpack-0.0.17-SNAPSHOT.jar
Wrote /root/project/pom.xml
Deploying {[:extension jar] /root/project/target/backpack-0.0.17-SNAPSHOT.jar, [:extension pom] /root/project/pom.xml} to [clojars {:url https://clojars.org/repo, :password REDACTED, :username REDACTED, :sign-releases false}]
Retrieving io/jesi/backpack/0.0.17-SNAPSHOT/maven-metadata.xml 
    from https://clojars.org/repo/
Sending io/jesi/backpack/0.0.17-SNAPSHOT/backpack-0.0.17-20181009.110407-2.jar (37k)
    to https://clojars.org/repo/
Sending io/jesi/backpack/0.0.17-SNAPSHOT/backpack-0.0.17-20181009.110407-2.pom (6k)
    to https://clojars.org/repo/
Retrieving io/jesi/backpack/maven-metadata.xml from https://clojars.org/repo/
Sending io/jesi/backpack/0.0.17-SNAPSHOT/maven-metadata.xml (1k)
    to https://clojars.org/repo/
Sending io/jesi/backpack/maven-metadata.xml (1k)to https://clojars.org/repo/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that It's not leiningen doing the actual deploy, and rather Maven.

},
singleRun: true,
retryLimit: 0
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woud this be good to add into parent?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better is some shared build project. Parent should be for managing dependencies. Maybe a public version of build-scripts

package.json Outdated
"karma": "^2.0.4",
"karma-chrome-launcher": "^2.2.0",
"karma-cljs-test": "^0.1.0",
"shadow-cljs": "^2.4.5",
"standard": "^11.0.1"
"shadow-cljs": "^2.6.10"
}
}
Copy link
Contributor Author

@axrs axrs Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is comitted so CI can install deps (and cache them) and shadow-cljs can find them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use dry on CircleCI, it's in build-bus.
Could use package-lock.json for caching but that file could change if the node versions are not the same (local vs CI).

README.md Outdated
:dependencies [[io.jesi/backpack "VERSION"]])
```
Active branches will automatically be suffixed with `-SNAPSHOT` prior to snapshot deploy to indicate a work-in-progress
and likely to actively changing build.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wording of this is weird, and does it need to be over two lines?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is and likely to change build. better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change wording and the whole layout

.idea/misc.xml Outdated
<option name="projectFiles">
<list>
<option value="file://$PROJECT_DIR$/project.clj" />
<option value="file://$PROJECT_DIR$/build-scripts/parent-clj/project.clj" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

test-docs () {
echo_message 'Verifying animal facts...'
docs
if ! git diff --quiet --exit-code docs;then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails if docs folder has uncommitted changes

Copy link
Contributor Author

@axrs axrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes.

node_cache: &NODE_CACHE
key: node-{{ checksum "/tmp/.node_version" }}-{{ checksum "package.json" }}
key: node-{{ checksum "/tmp/.node_version" }}-{{ checksum "package-lock.json" }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use package-dry.json. It will force a new cache when we change parent version. Might be the issue where tests failed recently too

CHANGELOG.md Outdated
@@ -0,0 +1,3 @@
## 0.0.17 (todo)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add date in todo

@AndreTheHunter AndreTheHunter merged commit b6c4939 into master Oct 16, 2018
@AndreTheHunter AndreTheHunter deleted the self-help branch October 16, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants