fix: implement fixes to work with eslint 8.57.0 #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These failures do not appear to be related to my changes: |
|
ping @SimenB can I get your help merging & releasing this please? It's a hard blocker for using eslint 8.57.0 with this lib so I'd love to get it out as soon as possible. Thanks in advance! |
ljharb
reviewed
Feb 28, 2024
|
Seems Node backported to 18.19.0 a change originally in v19 that breaks fake timers in Jest 28. Wonderful... |
|
Ok, just skipped over the broken node+jest combo in #230 - this should pass CI now 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements updates the eslint dependency to 8.57.0 and fixes the error
'reportUnusedDisableDirectives' has been removed. Please use the 'overrideConfig.linterOptions.reportUnusedDisableDirectives' option instead..In doing this, I also made the following improvements:
loadESLintfunction to loadESLintorFlatESLint, rather than using our own logicnormalizeConfig.jsfile to have explicit separate config shapes for the legacy config and the flat config. This also removes the need to have the code to deal with invalid config variables that we had hereNote that #1 makes this library incompatible with using the flat config format with eslint < 8.57.0. But I think that's OK given that 1) the flat config was experimental anyways and 2) if someone had a use case for locking eslint < 8.57.0, they could just as easily also lock jest-runner-eslint to v2.1.2. It's technically a breaking change, but I don't think it absolutely must be marked as such.