Skip to content

Use jest-diff config instead of strip-ansi #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thymikee opened this issue Feb 4, 2020 · 0 comments · Fixed by #123
Closed

Use jest-diff config instead of strip-ansi #113

thymikee opened this issue Feb 4, 2020 · 0 comments · Fixed by #123
Labels
good first issue

Comments

@thymikee
Copy link
Member

thymikee commented Feb 4, 2020

jest-diff has now config for getting rid of colors, so we can leverage that instead of using strip-ansi. See: #110 (comment) cc @pedrottimark.

This sounds like a good first contribution to the project :)
alistairjcbrown added a commit to alistairjcbrown/snapshot-diff that referenced this issue Apr 26, 2020
@alistairjcbrown
Use jest-diff options to turn off colors in diff
098cafb 
Make use of the new jest-diff options which allow color output to be
controlled. Use of example in documentation to turn off all color
output. strip-ansi is now unnecessary and has been removed as a
dependency.

Fixes jest-community#113
@alistairjcbrown alistairjcbrown mentioned this issue Apr 26, 2020
Merged
thymikee pushed a commit that referenced this issue Apr 27, 2020
@alistairjcbrown
Use jest-diff options to turn off colors in diff (#123)
ca9c069 
Make use of the new jest-diff options which allow color output to be
controlled. Use of example in documentation to turn off all color
output. strip-ansi is now unnecessary and has been removed as a
dependency.

Fixes #113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use jest-diff options to turn off colors in diff alistairjcbrown/snapshot-diff
1 participant
@thymikee