Skip to content

Support snapshot testName in toMatchDiffSnapshot #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PhoenixHe-NV opened this issue Nov 21, 2018 · 5 comments
Closed

Support snapshot testName in toMatchDiffSnapshot #56

PhoenixHe-NV opened this issue Nov 21, 2018 · 5 comments

Comments

@PhoenixHe-NV
Copy link

snapshot-diff/src/index.js

Line 94 in 447dea4

return snapshot.toMatchSnapshot.call(this, difference);

Could we pass argument testName here?
@thymikee
Copy link
Member

What's your use case?

@PhoenixHe-NV
Copy link
Author

Oh I see I could annotate the snapshot with aAnnotation and bAnnotation. But it could be nice if the testName could be set and shown in .snap file.

@thymikee
Copy link
Member

I'm confused, the test name is already in the snap file.

@PhoenixHe-NV
Copy link
Author

https://jestjs.io/docs/en/snapshot-testing#3-use-descriptive-snapshot-names
https://jestjs.io/docs/en/expect#tomatchsnapshotpropertymatchers-snapshotname

I mean the snapshotName argument

@thymikee
Copy link
Member

Yea that makes sense

@thymikee thymikee mentioned this issue Jan 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhoenixHe-NV @thymikee