chore: type invariant as assert function #9228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9228 +/- ##
==========================================
- Coverage 65.08% 65.06% -0.02%
==========================================
Files 278 278
Lines 11865 11864 -1
Branches 2925 2924 -1
==========================================
- Hits 7722 7719 -3
- Misses 3516 3518 +2
Partials 627 627
Continue to review full report at Codecov.
|
SimenB
commented
Nov 24, 2019
| @@ -351,8 +351,11 @@ export const addErrorToEachTestUnderDescribe = ( | |||
| } | |||
| }; | |||
|
|
|||
| export const invariant = (condition: unknown, message?: string) => { | |||
| export function invariant( | |||
There was a problem hiding this comment.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
typeSafety++Test plan
Green CI