Issue #13543 fix flakey TestStopMojo #13642
Merged
+133
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
reviewed
Oct 1, 2025
...tty-ee9-maven-plugin/src/test/java/org/eclipse/jetty/ee9/maven/plugin/TestJettyStopMojo.java
Outdated
Show resolved
Hide resolved
...tty-ee9-maven-plugin/src/test/java/org/eclipse/jetty/ee9/maven/plugin/TestJettyStopMojo.java
Outdated
Show resolved
Hide resolved
...tty-ee9-maven-plugin/src/test/java/org/eclipse/jetty/ee9/maven/plugin/TestJettyStopMojo.java
Outdated
Show resolved
Hide resolved
...tty-ee9-maven-plugin/src/test/java/org/eclipse/jetty/ee9/maven/plugin/TestJettyStopMojo.java
Outdated
Show resolved
Hide resolved
olamy
previously approved these changes
Oct 1, 2025
|
Done, ready for re-review |
|
@olamy can you rereview pls? |
olamy
requested changes
Oct 6, 2025
...y-ee10-maven-plugin/src/test/java/org/eclipse/jetty/ee10/maven/plugin/TestJettyStopMojo.java
Outdated
Show resolved
Hide resolved
| Awaitility.await().until(shutdownService::isListening); | ||
|
|
||
| //wait forever until our shutdown service stops this process | ||
| while (true) |
There was a problem hiding this comment.
why is it different in 10/11 and here?
There was a problem hiding this comment.
Ooops, forgot to do this in ee10 and ee11. Fixed now
|
Ready for re-re-review :) |
olamy
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for #13543.
@olamy if you like the approach I've done for
ee9I'll do it for the other environments too.