Issue #13290 - Consume WebSocket buffers in CoreSession.sendFrame #13643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…1.x/13290/websocket-consume-buffers-sendFrame
sbordet
requested changes
Oct 15, 2025
...t-core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/FragmentExtension.java
Outdated
Show resolved
Hide resolved
...cket-core-common/src/main/java/org/eclipse/jetty/websocket/core/util/FragmentingFlusher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
…1.x/13290/websocket-consume-buffers-sendFrame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13290
This reduces the number of times we do a
ByteBuffer.slice()when sending a frame in WebSocket, now the buffer of the Frame is consumed after the call toCoreSession.sendFrame.Currently this PR has the potential to impact users of Jetty / Jakarta WebSocket, as now the ByteBuffers sent with the sendBinary methods will consume the buffer.
But the Jakarta API now does specify that the container should consume the ByteBuffer (see discussion on jakartaee/websocket#209).