Fixes #13246 - Missing hook or statistic for QoSHandler rejections by exceeding setMaxSuspendedRequestCount. #13651
+110
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exceeding setMaxSuspendedRequestCount. Added more statistic counters to QoSHandler. Signed-off-by: Simone Bordet <[email protected]>
lorban
requested changes
Oct 6, 2025
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/QoSHandler.java
Outdated
Show resolved
Hide resolved
| private final AtomicInteger state = new AtomicInteger(); | ||
| private final Map<Integer, Queue<Entry>> queues = new ConcurrentHashMap<>(); | ||
| private final Set<Integer> priorities = new ConcurrentSkipListSet<>(Comparator.reverseOrder()); | ||
| private final AtomicLong totalCount = new AtomicLong(); |
There was a problem hiding this comment.
AtomicLong vs LongAdder: we sometimes use the former, sometimes the latter, throughout the classes in which we collect stats.
What's the motivation for using AtomicLong rather than LongAdder here?
There was a problem hiding this comment.
Given that this class limits concurrency of requests, contention should not be extreme. Furthermore, we use AtomicInteger for state, so make sense to use AtomicLong for totalCount, which are probably the 2 fields exposed to most contention.
Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more statistic counters to QoSHandler.