-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
build issues with 7.8 #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, cabal sdist runs alex and happy and puts the generated parser This will be very problematic if there's not a single version Can you do 'cabal sdist' to generate a tarball using GHC 7.8, and +++ Carter Tazio Schonwald [Jan 30 14 16:05 ]:
|
Alex / Happy for 7.8 generate incompatible code for 7.6 and earlier, this is a known breaking change. This has to do with Bool being Int# internally in in 7.8 (to allow branchless && and || codes more easily), whereas in 7.6 and earlier they dont. GHC / Haskell platform both come with Alex and Happy by default (as best I understand it), what prevents the alex / happy invocation from being at user build time? |
i'll dig deeper into this, maybe the right solution is to get alex / happy to generate CPP for handling the split, or perhaps it does alraedy. Mind you i don't have 7.6 setup locally right now, i'll explore later |
that said, what was the original reason for having the preprocessors run at sdist time? |
heres links to a gist each of lex.x parse.y for the the SDIST https://gist.github.com/cartazio/8755770 heres the relevant piece that I think captures the main difference. IF you can get these two modules to play nice with 7.6, i think things may be ok. I could be wrong though. (and may not have the time to test this weekend sadly) |
+++ Carter Tazio Schonwald [Feb 01 14 09:46 ]:
I believe that is the default behavior of 'cabal sdist', not something |
@jgm I'm told that you use the newest alex/ happy, the associated generated code will play nice with boht 7.8 and older ghc. (ie cabal update ; cabal install alex happy) |
OK, I regenerated the tarball using the latest alex and happy. +++ Carter Tazio Schonwald [Feb 02 14 16:06 ]:
|
is this the new version on hackage? testing it now. Looks like its built the haddock reader without a hitch! (though still in the proces of building mind you) Btw, regex-tdfa is currently broken on hackge for 7.8, so i'm using a patched copy locally. (this is an issue upstream of you. also was the subject of a recent cafe thread.) |
yup builds successfully. Thanks |
Great, thanks for your help. +++ Carter Tazio Schonwald [Feb 03 14 15:08 ]:
|
no, thank you for building great tools, being responsive, and super helpful! (its why i'm happy to do this debugging ever year or two :P ) btw, I"ll be in the berkeley / bay area feb 5-16, aren't you based in that area? |
+++ Carter Tazio Schonwald [Feb 03 14 16:05 ]:
Yep, I'm in Berkeley. Send me an email if you like, when you're in town. |
the current version on hackage seems to have some pre generated code that doesn't play nice with ghc 7.8, possibly due to alex / happy changes.
when i build from current master (todays), assuming a patched regex-pcre-builtin and a patched pandoc types, everything works.
The text was updated successfully, but these errors were encountered: