Preserve attributes on HTML paragraphs #10850
Conversation
- HTML reader wraps attributed `p` tags in `Div` with `wrapper="1"`. - HTML writer unwraps `Div` with `wrapper="1"` back to attributed `p` tag. - Add tests for HTML paragraph attribute roundtrip. - Update EPUB golden files to reflect new AST for attributed paragraphs.
Split pPara into pParaWithWrapper and pParaSimple helpers. Ensure pParaWithWrapper correctly discards invalid align attributes. Add specific tests for align attribute in HTML reader and writer.
- Update MANUAL.txt to reflect `native_divs` wrapping of attributed `<p>` tags.
- Add test cases for HTML to native, native to HTML, HTML to HTML, and HTML to HTML5 conversions - Verify preservation of id, class, and data attributes on p tags
There was a problem hiding this comment.
Thanks for this. As noted I didn't understand the special treatment of "align".
Another question I have is how common it is for paragraphs to have classes or other attributes in HTML in the wild. If it is very common, then I suppose this change will lead to more cluttered HTML -> markdown conversions and we'd need to weight that.
| pParaWithWrapper :: PandocMonad m => Attr -> TagParser m Blocks | ||
| pParaWithWrapper (ident, classes, kvs) = do | ||
| guardEnabled Ext_native_divs -- Ensure native_divs is enabled for this behavior | ||
| pInhalt <- trimInlines <$> pInTags "p" inline |
There was a problem hiding this comment.
I usually use the naming convention of beginning parsers with p; so it would be better to use something like inhalt instead for this name.
| let otherKVs = filter (\(k,_) -> k /= "align") kvs | ||
| let validAlignKV = case alignValue of | ||
| Just algn | algn `elem` ["left","right","center","justify"] -> [("align", algn)] | ||
| _ -> [] | ||
| let finalKVs = wrapperAttr : (validAlignKV ++ otherKVs) |
There was a problem hiding this comment.
What is the motivation for treating the "align" attribute specially in this way?
| return (case alignValue of | ||
| Just algn | algn `elem` ["left","right","center","justify"] -> | ||
| B.divWith ("", [], [("align", algn)]) paraBlock |
There was a problem hiding this comment.
I don't understand the motivation for this.
This PR implements the preservation of attributes on HTML paragraphs, addressing issue #10768.
HTML reader now wraps attributed <p> tags in a Div with wrapper="1".
HTML writer unwraps these Divs back to attributed <p> tags.
This approach is similar to the Djot reader/writer as discussed in #10768, ensuring that semantic information in HTML attributes on paragraphs is preserved during conversion.