Skip to content

Update comments #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Update comments #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/bundler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ export default function (app) {
// Set the content base, where the files are served from
contentBase: path.join(__dirname, 'public'),

// Tell Webpack to serve our bundled application from the assets path. When proxying:
// http://localhost:3000/assets -> http://localhost:8080/assets
// Tell Webpack to serve our bundled application from the bundle path. When proxying:
// http://localhost:3000/bundle -> http://localhost:3001/bundle
publicPath: '/bundle/',

// Configure hot replacement
Expand All @@ -49,7 +49,7 @@ export default function (app) {
// Create a proxy to serve files to the app server from the webpack dev server
const proxy = httpProxy.createProxyServer();

// Any requests to localhost:3000/assets is proxied
// Any requests to localhost:3000/bundle is proxied
// to webpack-dev-server
app.all(['/bundle/*', '*.hot-update.json'], function (req, res) {
proxy.web(req, res, {
Expand Down