Skip to content

Add Legacy Comparison Flag #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: parse-cabal-project-parsec
Choose a base branch
from
Open

Add Legacy Comparison Flag #1

wants to merge 42 commits into from

Conversation

jgotoh
Copy link
Owner

@jgotoh jgotoh commented Jan 24, 2025

Please read Github PR Conventions and then fill in one of these two templates.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

jgotoh added 30 commits January 10, 2025 22:40
@jgotoh
Replace cabal project parsing with Parsec
82c243d
@jgotoh
Replace haddock-lib with haddock-resources-dir
e3373be
@jgotoh
Add parsing of ClientInstallFlags
ebd6c9f
@jgotoh
Add parsing of InstallDirs
e5cbba4
@jgotoh
Add missing constraintKinds
24440c9
@jgotoh
Update docs and remove comment
2ed99c1
@jgotoh
Extract testInstallDirs into separate test
06455e1
@jgotoh
Add RemoteRepos and LocalNoIndexRepos test stubs
63aee4e
@jgotoh
Add RemoteRepos test
6f34619
@jgotoh
Add LocalNoIndexRepos Test
e92f951
@jgotoh
Update only compare parsed values of repositories
c1f8071
@jgotoh
Add Distribution.Client.Utils.Newtypes module
9ceadbc
@jgotoh
Add RemoteRepo Lenses
f3f2a02
@jgotoh
Add RemoteRepo FieldGrammar
8a1abbc
@jgotoh
Add parsing of repository sections
ce0a82d
@jgotoh
Fix RemoteRepo test
dbab8c4
@jgotoh
Improve stateConfig lense usage
7b22c88
@jgotoh
Add filtering fields to parseProgramArgs/Paths
bb6f939
@jgotoh
Fix imports of test
a0f82c0
@jgotoh
Add parsing of profiling-shared and use-unicode
37d592c
@jgotoh
Add changelog
b727bd0
@jgotoh
Migrate ParserTests to cabal-install/parser-tests
55d5765
@jgotoh
Add monoidal parsing of AllowNewer and AllowOlder
5959feb
@jgotoh
Fix order of programArgs parsing
32de2a3
@jgotoh
Fix parsing of commas in programArgs
b5e69e3
@jgotoh
Add quotes in programOptions test
7e5df6a
@jgotoh
Update programArgs parser to allow Quotes
5cb80ad
@jgotoh
Fix order of imports
6919f72
@jgotoh
Update PackageDBNT to use PackageDBCWD
7d25cbd
@jgotoh
Fix ParserTests to use PackageDBX
d9c616a
jgotoh added 12 commits January 10, 2025 22:40
@jgotoh
Fix TOCTOU
146d907
@jgotoh
Add library-coverage test
e2d6e2d
@jgotoh
Add parsing of haddock-all flag
051d2e5
@jgotoh
Renamed LiftParseResult, pure composition
0df3041
@jgotoh
Fix intToOptimisationLevel dynamic bounds
91f6317
@jgotoh
Add cabal-install:parser-tests to cabal-validate
1265975
@jgotoh
Fix maxLevel comparison
5b0c35a
@jgotoh
Fix regression test and issue url
7d7707f
@jgotoh
Fix exports in ProjectConfig
b641acd
@jgotoh
Add Parsec Subsection Warning to test
462a345 
Expects Invalid subsection warning by the Parsec ProjectConfig parser.
Currently the warning is issued twice:
First warning: "Warning: <ROOT>/else.project, else.project: Unrecognized
section '_' on line 3" is issued by the legacy parser,
Second warning: "Warning: dir-else/else.config:3:5: Invalid subsection
"_"" by Parsec Parser.
When we remove executing the legacy parser, we can remove the duplicate warning.
@jgotoh
Fix T5213 cabal.out warning order
eededa4
@jgotoh
Add Legacy Comparison Flag
2c593ca
@jgotoh jgotoh force-pushed the add-legacy-comparison-flag branch from adf676b to 2c593ca Compare January 24, 2025 13:36
@jgotoh jgotoh force-pushed the parse-cabal-project-parsec branch from eededa4 to 8e08b0c Compare February 24, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jgotoh