fix usage of fcntl(..., F_GETFL, ...) #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until about 5 minutes ago (at least in bleadperl), the documentation for fcntl() had included an incorrect example:
This is incorect, fcntl() with the FUNCTION set to F_GETFL returns the value, it doesn't store the result in the SCALAR parameter.
Unfortunately this incorrect usage is reflected in IPC::Cmd, this pull request fixes these calls.
This worked despite the incorrect code because F_SETFL ignores most of the possible flags that F_GETFL returns, eg. F_SETFL won't modify F_RDWR.