Skip to content

fixes #142: prevent nil error for major and minor version parsing #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes #142: prevent nil error for major and minor version parsing #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7842fde
fix(sw version issue): prevent nil error for major and minor version …
CsBigDataHub Jul 18, 2025
df151f5
Update build-emacs-for-macos
CsBigDataHub Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions build-emacs-for-macos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,11 @@ class AbstractVersion
attr_reader :version

def initialize
@version = load_version.match(
str = load_version.strip
@version = str.match(
/(?<major>\d+)(?:\.(?<minor>\d+)(?:\.(?<patch>\d+))?)?/
)
warn "Parsed OS version string: '#{str}' => #{@version ? @version[0] : 'NIL'}"
end

def load_version
Expand All @@ -164,15 +166,15 @@ class AbstractVersion
end

def major
@major ||= @version[:major]&.to_i
@major ||= (@version && @version[:major]) ? @version[:major].to_i : 0
end

def minor
@minor ||= @version[:minor]&.to_i
@minor ||= (@version && @version[:minor]) ? @version[:minor].to_i : 0
end

def patch
@patch ||= @version[:patch]&.to_i
@patch ||= (@version && @version[:patch]) ? @version[:patch].to_i : 0
end
end

Expand Down