Fix: for duplicate education entries #254
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when scraping a profile, the
get_educations()
method was adding the same education entry multiple times to the final list. This seems to be caused by the scraper matching multiple HTML elements for a single entry on the education details page.Solution:
This pull request fixes the issue by:
scraped_education_keys
set in thePerson
class.get_educations()
, it creates a unique key for each scraped entry.Education
object if its key hasn't been seen before.This ensures that each education is only recorded once. I also restored the
scrape_logged_in
method which appeared to have been accidentally deleted in the version I had.Thanks for your consideration!