Skip to content

Function in "sort with a function" test should be a comparator #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

iamstolis
Copy link
Contributor

The function used in "should sort with a function" is not a comparator. Not that a function passed to Array.sort should follow some rule that the previous function was violating. It is just a coincidence that the test was passing.

The function used in "should sort with a function" is not a comparator. Not that a function passed to `Array.sort` should follow some rule that the previous function was violating. It is just a coincidence that the test was passing.
@doowb
Copy link
Collaborator

doowb commented Jul 24, 2017

@iamstolis thanks for the PR! Sorry for the delay in responding.

@doowb doowb merged commit 62f225d into jonschlinkert:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants