Skip to content

Conversation

til
Copy link

@til til commented Mar 16, 2016

Rename *.css to *.css.scss

This fixes the issue reported in #32 for me and is an alternative to PR #33 - this way rails automatically compiles the scss files.

@til
Copy link
Author

til commented Mar 16, 2016

Sorry about the slightly premature PR, since I had this lying around I thought I might as well just push it, but now realize that it is possible to use rails without scss, so this approach would not work then. Not sure what is the best way to deal with this - maybe add sass-rails as dependency?

@jordanbrock
Copy link
Owner

As mentioned in #33 I'd prefer to add sass-rails as a dependency because having raw css files just adds complexity to the project.

Yes it's possible to use rails without scss, but it's in there by default. If you're stripping components out then you've got to expect to make compromises along the way?

Thoughts?

@holetse
Copy link

holetse commented Mar 24, 2016

I think its totally reasonable to add sass-rails as a dependency. The current version of this gem fails to work because .css is not automatically preprocessed by rails, and it contains invalid CSS. Since the gem does actually require sass-rails in its current implementation, calling out the dependency and merging this PR seems like the right away forward.

At a later point, @jordanbrock, you could explore alternatives to requiring sass-rails, but that seems to be a separate issue and one that does not need to be tackled today.

@FQ400
Copy link

FQ400 commented Sep 8, 2016

+1 adding sass-rails as dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants