Small saftey and annoyance updates to bin/update.py #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we only use the latest emoji-zwj-sequences.txt for automatic testing purposes, a static change of the URL is performed without "legacy url" support for support of previous versions. From https://unicode.org/Public/emoji/ReadMe.txt > This directory contains data files for versions 1.0 to 16.0 > of Unicode Emoji. > > Starting with Unicode 17.0.0, the data files for Unicode Emoji are published in > https://www.unicode.org/Public/<version>/emoji/ > together with the related files in > https://www.unicode.org/Public/<version>/ucd/emoji/ I checked, and this file does not change in value between 15.1.0 and 17.0.0; and, new code has been added to *verify* that no change is done. This is because we hardcode *all* vs16 tables as a single "version 9.0.0" table,
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
penguinolog
reviewed
Sep 30, 2025
bin/update-tables.py
Outdated
| if (line.startswith('@@') or | ||
| line.startswith('---') or | ||
| line.startswith('+++') or | ||
| (line.startswith('-') and 'This code generated') or |
There was a problem hiding this comment.
right side inside brackets is always implicit evaluated as True
There was a problem hiding this comment.
oh right, thanks, I had to re-read it a few times to see the bug thanks
penguinolog
reviewed
Sep 30, 2025
bin/update-tables.py
Outdated
| # Check if only the 'This code generated' line is different | ||
| significant_changes = False | ||
| for line in diff_lines: | ||
| if (line.startswith('@@') or |
There was a problem hiding this comment.
Re-readed and understood: https://docs.python.org/3/library/stdtypes.html#str.startswith
You can use line.startswith(('@@', '---')) and list all prefixes in the tuple instead of multiple or. Code will look cleaner.
penguinolog
reviewed
Sep 30, 2025
reduce code, use tuple in startswith() Co-authored-by: Aleksei Stepanov <[email protected]>
…o jq/bin-update-updates
penguinolog
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not modify timestamps in code generated files (discard if timestamp is the only "difference". Unless table_vs16.py has changed code; this is significant and would require a code change because of our hardcoded 9.0.0 release.
URL_EMOJI_ZWJ is updated, From https://unicode.org/Public/emoji/ReadMe.txt