Support filtering across relations (apply joins / fix column name). Fixes #18 #21
Conversation
|
I've got hand it to you, I'm impressed you waded through that gnarly relations code and refactored it. 👏 One thing, can you squash your commits into a single commit? |
techniq
force-pushed
the
filter-joins
branch
3 times, most recently
from
67b148a to
3f74c25
Compare
|
Squashed. I wasn't sure how verbose you wanted the commit message (I left the individual commit messages in the squashed commit). No worries on the code, I used it as a learning exercise 😀 This PR only supports simple filtering (basically a single "foreign property" can be specified). If we need to support more complex filtering, we probably need to look at creating aliases on the joined tables and keeping track of what we've joined against already. I'm might try to knock out filtering within the same chain of relations. For example: var comments = yield adapter.findAll(Comment, { 'user.name': 'John' , 'user.profile.email': '[email protected]'})Right now js-data-sql creates a join from I'll send this improvement as a separate PR when I get time 😀 |
…ixes js-data#18 Consolidate and simplify loading of "with" relations for both find and findall Yield promises with generator instead of chaining promises when cleaning up tests Simplify looking up table name from resource config Remove unnecessary logging
|
Disregard the comment about filtering within the same chain of relations, I implemented that and amended this PR 😀 |
Support filtering across relations (apply joins / fix column name). Fixes #18
|
I'll cut a release tonight. |
|
👍 |
No description provided.