Skip to content

Add support for custom queries. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Add support for custom queries. #36

merged 1 commit into from
Oct 26, 2015

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Oct 24, 2015

No description provided.

@jmdobry
Copy link
Member Author

jmdobry commented Oct 24, 2015

Needs tests

@techniq
Copy link
Member

techniq commented Oct 26, 2015

@jmdobry I added some tests and our test coverage went down. Looking at the coveralls report confuses me :(

@jmdobry
Copy link
Member Author

jmdobry commented Oct 26, 2015

This .only might be why, only 6 of the tests actually ran.

@techniq
Copy link
Member

techniq commented Oct 26, 2015

Doh. I'll fixed that in the morning

On Mon, Oct 26, 2015, 12:12 AM Jason Dobry [email protected] wrote:

This .only

describe.only('DSSqlAdapter#filterQuery', function () {

might be why, only 6 of the tests actually ran.


Reply to this email directly or view it on GitHub
#36 (comment).

@techniq
Copy link
Member

techniq commented Oct 26, 2015

Fixed and squashed the branch

jmdobry added a commit that referenced this pull request Oct 26, 2015
Add support for custom queries.
@jmdobry jmdobry merged commit 94859ef into develop Oct 26, 2015
@jmdobry jmdobry deleted the query branch October 26, 2015 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants