Support IS NOT NULL in query syntax #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mechanicalpulse It looks like your test includes the One last thing and I'll merge it in and tag a release for you... could you also cover the |
|
I added the test case just in case something changes in knex. Do you think it would be more appropriate to specifically handle the whereNull case instead of relying on knex's behavior? |
|
@mechanicalpulse I don't see it being a bad thing to handle it explicitly, just in case knex's behavior changes |
techniq
added a commit
that referenced
this pull request
Dec 7, 2015
Support IS NOT NULL in query syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, I see queries like
WHERE field != NULL, which doesn't work in MySQL (and possibly other SQL dialects).