Skip to content

volantis.js.org #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

volantis.js.org #4857

wants to merge 3 commits into from

Conversation

MHuiG
Copy link
Contributor

@MHuiG MHuiG commented Oct 24, 2020 •
edited
Loading

Revert #4854 It's a wrong pr.

MattIPv4
MattIPv4 requested changes Oct 24, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this into two PRs, one PR for each js.org subdomain being updated.

@MHuiG MHuiG changed the title volantis-x.js.org volantis.js.org Oct 24, 2020
@MHuiG MHuiG requested a review from MattIPv4 October 24, 2020 16:30
MattIPv4
MattIPv4 reviewed Oct 24, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to where the new content can be previewed?

@MattIPv4 MattIPv4 added awaiting response This PR is waiting for a response from the requester and removed invalid labels Oct 24, 2020
@MHuiG
Copy link
Contributor Author

MHuiG commented Oct 24, 2020

see here: xaoxuu/volantis.js.org@942b567

@MHuiG
Copy link
Contributor Author

MHuiG commented Oct 24, 2020

Slide down to the bottom and you'll see the link

@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester labels Oct 24, 2020
@indus
Copy link
Member

indus commented Oct 24, 2020

Welcome https://volantis.js.org

@indus
Copy link
Member

indus commented Oct 24, 2020

Merged manually 0f68ed4
(Is this correct?)

@indus indus closed this Oct 24, 2020
@MHuiG
Copy link
Contributor Author

MHuiG commented Oct 24, 2020

Oh, yes, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MHuiG @indus @MattIPv4