Skip to content

Fixed to initialize props when component is unmounded #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed to initialize props when component is unmounded #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions page/src/containers/LogModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class LogModal extends Component {

this.onLive = this.onLive.bind(this);
this.onChange = this.onChange.bind(this);
this.closeModal = this.closeModal.bind(this);
}

onLive() {
Expand Down Expand Up @@ -55,12 +56,19 @@ class LogModal extends Component {
};
}

closeModal() {
this.props.closeHandler('logModal');
this.setState({
logs: []
});
}

render() {
const { open, closeHandler } = this.props;
const { open } = this.props;
const { logs, token } = this.state;

return (
<Modal id="log__modal" size="tiny" open={open} onClose={() => closeHandler('logModal')}>
<Modal id="log__modal" size="tiny" open={open} onClose={this.closeModal}>
<Header icon="fort awesome" content="live log" />
<Modal.Content>
<Form>
Expand All @@ -74,7 +82,7 @@ class LogModal extends Component {
<LogList logs={logs} />
</Modal.Content>
<Modal.Actions>
<Button color="grey" onClick={() => closeHandler('logModal')}>
<Button color="grey" onClick={this.closeModal}>
<Icon name="close" /> close
</Button>
</Modal.Actions>
Expand Down
3 changes: 2 additions & 1 deletion page/src/containers/NavBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ class NavBar extends Component {

handleClick(name) {
this.setState({
[name]: !this.state[name]
[name]: !this.state[name],
registerInfo: 'Add a bot https://my.slack.com/services/new/bot and put the token'
});
}

Expand Down