Skip to content

Organize files #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Organize files #208

wants to merge 22 commits into from

Conversation

asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK commented May 10, 2025

  • Created utils/camelize.js
  • Put generated files under generated/
  • Switched to const and let
  • Updated code style rules through prettier
  • Added @domenic/eslint-config rules
  • Updated CSSStyleDeclaration class to match the latest spec
  • Rewritten properties/*.js files
  • Renamed test files -> *.test.js and added tests

Fixes #200, Fixes #201, Fixes #202, Fixes #203, Fixes #204, Fixes #205,
Fixes #206, Fixes #207, Fixes #70, Fixes #124
Also we can close #120, I think.

@asamuzaK asamuzaK force-pushed the files branch 2 times, most recently from 5764bbc to b667bdf Compare May 10, 2025 08:35
@asamuzaK asamuzaK marked this pull request as draft May 11, 2025 01:20
@asamuzaK asamuzaK force-pushed the files branch 2 times, most recently from 1455bf8 to 529cd2d Compare May 12, 2025 21:04
@asamuzaK
Copy link
Contributor Author

asamuzaK commented May 13, 2025

@domenic
Almost ready.

Do you think we still need webkitXXX.js files under ./properties/?
Is it okay to remove them?

@domenic
Copy link
Member

domenic commented May 13, 2025

I'm not sure I understand enough project architecture to know exactly what those files are currently doing.

We need to support this part of the spec: https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface:~:text=fontSize%20IDL%20attribute.-,For%20each%20CSS%20property%20property,exceptions%20thrown%20must%20be%20re%2Dthrown.,-For%20example%2C%20if . Do those files help with that?

@asamuzaK
Copy link
Contributor Author

I'm not sure I understand enough project architecture to know exactly what those files are currently doing.

We need to support this part of the spec: https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface:~:text=fontSize%20IDL%20attribute.-,For%20each%20CSS%20property%20property,exceptions%20thrown%20must%20be%20re%2Dthrown.,-For%20example%2C%20if . Do those files help with that?

Let's keep webkitFoo files for now.
I'll file new issue for that.

@asamuzaK asamuzaK force-pushed the files branch 2 times, most recently from 89f212d to c257ce5 Compare May 17, 2025 13:30
@asamuzaK asamuzaK marked this pull request as ready for review May 17, 2025 14:41
@asamuzaK asamuzaK requested a review from domenic May 17, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment