Skip to content

Import existing OpenApi integration #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maurei opened this issue Sep 1, 2021 · 0 comments · Fixed by #1076
Closed

Import existing OpenApi integration #1048

maurei opened this issue Sep 1, 2021 · 0 comments · Fixed by #1076
Labels

Comments

@maurei
Copy link
Member

maurei commented Sep 1, 2021

In a private repository we have experimented with integrating OpenAPI with JsonApiDotNetCore by:

  • adding the Swashbuckle SwaggerGen to a JADNC application.
  • generating a client using NSwag

We have decided to extract this code into this repository and further generalize the integration from there.

Along with the migration we will introduce a set of test models that reflect the models that were used in the private repository, and with it a test in which we compare the generated OAS with an hardcoded expected value. This will be useful to maintain as long as we haven't introduced dedicated test suites for every OpenApi feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant