-
-
Notifications
You must be signed in to change notification settings - Fork 158
Move existing integration to JADNC #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…reflect features that were covered in the private repository
…dels to make the client test pass without introducing any structural adjustments to the test codes
…tation, minor model adjustments
3f4fd7b
to
c6d691d
Compare
Codecov Report
@@ Coverage Diff @@
## openapi #1076 +/- ##
===========================================
+ Coverage 88.42% 88.82% +0.40%
===========================================
Files 258 306 +48
Lines 7039 8057 +1018
===========================================
+ Hits 6224 7157 +933
- Misses 815 900 +85
Continue to review full report at Codecov.
|
…hich is to be removed at the very end once have dedicated test suites for all components
322ad77
to
bad9aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at the docs so far, will review more another day.
…not yet supported and will cause the integration to crash
…otNetCoreExample project. The only call that currently doesn't crash is the one associated to deleting a primary resource
e26dac4
to
7b3d1ef
Compare
…rnal. Simplified ExampleApiClient to not use a generated interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with review pass. Please don't force-push anymore after the code review has started.
src/Examples/JsonApiDotNetCoreExampleClient/GeneratedCode/ExampleApiClient.cs
Outdated
Show resolved
Hide resolved
src/Examples/JsonApiDotNetCoreExampleClient/GeneratedCode/IExampleApiClient.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore.OpenApiClient/JsonApiDotNetCore.OpenApiClient.csproj
Outdated
Show resolved
Hide resolved
test/OpenApiClientTests/LegacyClient/ClientAttributeRegistrationLifeTimeTests.cs
Show resolved
Hide resolved
src/JsonApiDotNetCore.OpenApi/JsonApiMetadata/EndpointResolver.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore.OpenApi/SwaggerComponents/JsonApiSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore.OpenApi.Client/JsonApiDotNetCore.OpenApi.Client.csproj
Outdated
Show resolved
Hide resolved
…unrequired internalsVisibleTo usage
856af3b
to
da1db37
Compare
…ate repository of the legacy integration. Also processed some of the review feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with another review pass. Still pending:
- review tests, based on the doc you sent me
- update install steps in .md
- diff the swagger.json against internal prototype
test/OpenApiTests/ExistingOpenApiIntegration/ExistingOpenApiIntegrationStartup.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore.OpenApi.Client/JsonApiDotNetCore.OpenApi.Client.csproj
Outdated
Show resolved
Hide resolved
…' to 'OpenApi.Client'. Removed unneeded config from legacy integration startup.
…-dotnet/JsonApiDotNetCore into oa/existing-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed client tests
fbfdf56
to
5a4a06f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gone over client tests again. Looks good now, except what's listed. Pending: swagger.json
Closes #1048
In the effort of migrating the existing integration that lived in the private repository:
JsonApiDotNetCore.OpenApi
JsonApiDotNetCore.OpenApi.Client
project, which currently only introduces support for partial write requests for c# clients generated with NSwag.OpenApiTests
.JsonApiDotNetCoreExampleClient
project that generates a client for the example project based off the OpenAPI specification that was created using the OpenAPI integration in the example project.Closes #1049
ResourceNameFormatterProxy
withResourceNameFormatter
.Closes #1050
IApiRequestFormatMetadataProvider
, removing the input formatter workaround #1050 it was suggested to reconsider merging changes in Implement API format metadata provider interfaces #972, but it turns out this was never going to work for the OpenAPI integration because it provide metadata about types like for exampleResourceCollectionResponseDocument<TResource>
, which lives in the OpenAPI integration project and hence cannot be referenced in the main solution. The solution is to just introduce a dedicated formatter with the sole purpose of implementingIApiRequestFormatMetadataProvider
, which does not interfere with the regularJsonApiInputFormatter
, and which is only registered when the OpenAPI package is added to the JsonApiDotNetCore application.QUALITY CHECKLIST