Skip to content

When I utilize pagination for a result set that is filtered, the links should include the filters. #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
turingtestable opened this issue May 2, 2018 · 0 comments · Fixed by #275
Labels

Comments

@turingtestable
Copy link
Contributor

Were I to query in this way:
someBaseUrl/posts?page[size]=10&page[number]=1&filter[author]=eq:AuthorName

I would expect my relationships to reflect the filters, otherwise I will get weird data in return from the library.
Expected
"links": {
"next" : someBaseUrl/posts?page[size]=10&page[number]=2&filter[author]=eq:AuthorName
"last": someBaseUrl/posts?page[size]=10&page[number]=3&filter[author]=eq:AuthorName
}

Actual

"links": {
"next" : someBaseUrl/posts?page[size]=10&page[number]=2
"last": someBaseUrl/posts?page[size]=10&page[number]=3
}

turingtestable pushed a commit to turingtestable/JsonApiDotNetCore that referenced this issue May 4, 2018
This was referenced May 4, 2018
Merged
turingtestable pushed a commit to turingtestable/JsonApiDotNetCore that referenced this issue May 4, 2018
@jaredcnance jaredcnance added the bug label May 6, 2018
jaredcnance pushed a commit that referenced this issue Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants