Skip to content

Filtered params in pagination links missing '=' before the operator and ':' after the operator #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
effexe opened this issue May 7, 2018 · 0 comments · Fixed by #278
Labels

Comments

@effexe
Copy link

effexe commented May 7, 2018

Filtered parameters in pagination links are missing the equals sign and the operator.

Example:

"links": {
"last": "http://localhost/endpoint?page[size]=50&page[number]=1&filter[filter1]eqApplied&filter[filter2]eqPROD"
}

should be:

"links": {
"last": "http://localhost/endpoint?page[size]=50&page[number]=1&filter[filter1]=eq:Applied&filter[filter2]=eq:PROD"
}

@effexe effexe changed the title Sort params in pagiation links missing '=' and the operator Sort params in pagination links missing '=' and the operator May 7, 2018
@jaredcnance jaredcnance added the bug label May 7, 2018
@effexe effexe changed the title Sort params in pagination links missing '=' and the operator Filtered params in pagination links missing '=' and the operator May 7, 2018
@effexe effexe changed the title Filtered params in pagination links missing '=' and the operator Filtered params in pagination links missing '=' before the operator and ':' after the operator May 7, 2018
effexe pushed a commit to effexe/JsonApiDotNetCore that referenced this issue May 7, 2018
jaredcnance added a commit that referenced this issue May 7, 2018
FIxes #277, Added changes for fix and fixed tests
jaredcnance pushed a commit that referenced this issue Aug 12, 2018
jaredcnance added a commit that referenced this issue Aug 12, 2018
FIxes #277, Added changes for fix and fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants