Skip to content

Minimal Swashbuckle setup #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 8, 2021
Merged

Minimal Swashbuckle setup #1073

merged 25 commits into from
Sep 8, 2021

Conversation

maurei
Copy link
Member

@maurei maurei commented Sep 6, 2021

  • Introduces a very minimal OpenApi project in which the integration will live. It currently only contains the dependency on Swashbuckle and I've added a very minimal implementation of IActionModelConvention in order to not have a project without any code.
  • Introduces a full document test in a new test project in which a predefined document is checked against the document retrieved from Swashbuckle's endpoint for the OpenAPI specification.
  • Closes Minimal OpenApi integration #1047

@maurei maurei changed the base branch from master to openapi September 6, 2021 11:19
@maurei maurei changed the base branch from openapi to master September 6, 2021 12:03
@maurei maurei changed the base branch from master to openapi September 6, 2021 14:31
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (openapi@a3890fe). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 60adeac differs from pull request most recent head c236cad. Consider uploading reports for the commit c236cad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             openapi    #1073   +/-   ##
==========================================
  Coverage           ?   88.42%           
==========================================
  Files              ?      258           
  Lines              ?     7039           
  Branches           ?        0           
==========================================
  Hits               ?     6224           
  Misses             ?      815           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3890fe...c236cad. Read the comment docs.

@maurei maurei marked this pull request as ready for review September 6, 2021 15:27
@maurei maurei requested a review from bart-degreed September 6, 2021 15:37
@maurei maurei merged commit d226a0e into openapi Sep 8, 2021
@maurei maurei deleted the oa/minimal-setup branch September 8, 2021 08:41
bart-degreed pushed a commit that referenced this pull request Nov 9, 2021
bart-degreed pushed a commit that referenced this pull request Dec 3, 2021
bart-degreed pushed a commit that referenced this pull request Dec 3, 2021
bart-degreed pushed a commit that referenced this pull request Dec 3, 2021
nicolestandifer3 added a commit to nicolestandifer3/DotNet-Core-Json-Api that referenced this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Minimal OpenApi integration
2 participants