Skip to content

Fix/default page size #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 65 commits into from
Closed

Fix/default page size #600

wants to merge 65 commits into from

Conversation

maurei
Copy link
Member

@maurei maurei commented Oct 30, 2019

Closes #599

BUG FIX

  • reproduce issue in tests
  • fix issue
  • bump package version

maurei and others added 30 commits September 27, 2019 12:51
* feat: started work on decoupling

* feat: add total record count

* feat: green tests, new managers

* feat: changed startup

* feat: most annoying commit of my life, rewriting dozens of controllers

* feat: rename: QueryManager -> RequestManager, deeper seperation of concerns, 12 tests running...

* feat: removed JsonApiContext dependency from controller, fixed namespaced tests

* feat: decoupled controllers

* chore: renamed resourcegraphbuilder,  took out some extensions, made benchmarks work again

* feat: json api context decoupling mroe and more

* chore: readded solutions

* feat: upgrading to 2.2, setting contextentity in middleware

* fix: removed outdated authorization test

* fix: requestmeta tests

* fix: some acceptance tests

* fix: pagination

* fix: total records in meta

* feat: introduced JsonApiActionFilter

* fix: more tests
* feat: started work on decoupling

* feat: add total record count

* feat: green tests, new managers

* feat: changed startup

* feat: most annoying commit of my life, rewriting dozens of controllers

* feat: rename: QueryManager -> RequestManager, deeper seperation of concerns, 12 tests running...

* feat: removed JsonApiContext dependency from controller, fixed namespaced tests

* feat: decoupled controllers

* chore: renamed resourcegraphbuilder,  took out some extensions, made benchmarks work again

* feat: json api context decoupling mroe and more

* chore: readded solutions

* feat: upgrading to 2.2, setting contextentity in middleware

* fix: removed outdated authorization test

* fix: requestmeta tests

* fix: some acceptance tests

* fix: pagination

* fix: total records in meta

* feat: introduced JsonApiActionFilter

* fix: more tests

* feat: decoupled deserializer and serializer

* chore: remove / cleanup old serializers

* chore: remove operation services

* tests: unit tests client/server (de)serializers

* chore: various edits to run tests

* fix: rm dasherized resolver

* chore: remove JsonApiContext and corresponding interface

* chore: reorganize namespaces

* chore: rm old tests

* chore: rm unused document builder

* chore: add comments to deserialization classes

* chore: add comments

* chore: rm IJsonApiContext from sort attr instantiation

* feat: (re)introduced omit null value behaviour (and now omit default value behaviour too) using a serializer options provider

* chore: remove more jsonapicontext references

* chore: minor renames, add wiki for serialization

* chore: improve wiki

* chore: wiki

* chore: wiki

* chore: add a bunch of comments, renamed a few services

* chore: wired up nested sparse field selection

* chore: wired up omit behaviour

* chore: prettied some comments

* chore: remove (almost) all references to jsonapicontext in unit tests project

* chore: removed last bits of jsonapicontext

* fix: tests serialization passing again

* chore: rename included query service to include query service

* chore: improve comment

* chore: improve comment

* chore: delete jsonapicontext tests

* chore: remove space

* test: email config

* chore: rename client / server (de)serializer to request/response (de)serializer

* chore: rename client / server (de)serializer to request/response (de)serializer

* feat: introduce IQueryParameter

* chore: move request/response (de)serializer to client/server namespace for easier future isolation

* chore: update namespaces

* chore: rm textfile

* chore: fixing failing unit tests

* chore: rename query services, adjustment namespace

* chore: reorganised test files for serialization, added relationship path serialization tests

* feat: request relationship in response serializer

* chore: wired up response serializer in formatter layer

* feat: IGetRelationshipService now returns TResource instead of object, which decouples it from serializers requirements

* fix: support for serving document of resource type different from request resource, as required by resourceservice.getrelationships()

* chore: simplified linkbuilders

* chore: several fixes for e2e tests

* fix: various e2e tests, decoupled service layer from serialization format

* fix: inclusion edgecase

* chore: fix error formatting tests

* chore: naming consistency sparsefield and include query services

* chore: various adjustments to make e2e test project build and pass again

* chore: fix build various e2e tests

* chore: fix build various e2e tests

* fix: e2e test Can_Include_Nested_Relationships

* fix: e2e test Can_Patch_Entity

* fix: e2e test Patch_Entity_With_HasMany_Does_Not_Include_Relationships

* fix: e2e test Can_Create_Entity_With_Client_Defined_Id_If_Configured

* chore: rename base document parser and builder

* fix: e2e test Can_Create_Guid_Identifiable_Entity_With_Client_Defined_Id_If_Configured

* fix: unit tests various

* feat: reorganisation inheritance serialization layer

* fix: unit tests after inheritance update

* fix: wire up correct resource object builder implementation in serializers

* fix: e2e remaining CreatingDataTests

* chore: refactor creatingdata tests

* fix: e2e test paging

* fix: e2e controller tests

* chore: wiring up new resource object builders to dependency graph

* chore: response resource object builder unit test, restored repo and resourcedef unit tests

* chore: finishing touches comments serialization

* Feat/serialization wiki (#561)

* docs: add decoupling architecture, wiki folder

* docs: add v4 wiki

* chore: restructure of intro

* chore: v4
maurei and others added 26 commits October 17, 2019 18:14
Use relationships as navigations in sparse field queries
* refactor: move HasManyThrough GetValue and SetValue logic to HasManyThroughAttribute

* feat: remove GetPublicAttributeName from ResourceGraph and remove dependency on ResourceGraph of controller layer

* style: spacing in BaseJsonApiController<,>

* feat: remove GetEntityFromControllerName from ResourceGraph

* feat: remove GetInverseRelationship from ResourceGraph

* feat: decouples UsesDbContext from ResourceGraph and introduces decoupled application instantation

* chore: remove redundant injections of IResourceGraph

* refactor: merge IContextEntityProvider and IFieldsExplorer into IResourceGraphExplorer

* style: cleanup of variable names

* chore: various fixes for PR review, mostly style and variable naming

* style: rename IResourceGraphExplorer back to IResourceGraph, consitent usage of IContextEntityProvider

* docs: comments for DefaultActionFilter and DefaultTypeFilter

* docs: comments JsonApiApplicationBuilder

* style: consistent variable naming|

* chore: wire up IControllerResourceMapping

* refactor: routing convention implements controller mapping interface

style: DefaultResourceRepository and DefaultEntityService as consie 833da6a
style: rename old repository interfaces 							519513d
style: ContextEntity --> ResourceContext 							d038582
style: rename Entity to Resource 									f2e411c
style: TEntity --> TResource 										3af6f9b
style: DependentType, PrincipalType --> RightType, LeftType 		ce08b4f
style: replaced principal with left and dependent with right whenev b162519
chore: remove redundant bindings throughout entire codebase 		e509956
refactor: regroupe hook container and executors 					48495d3
style: IGenericProcessor --> IHasManyThroughUpdateHelper 			f19e606
chore: delete rogue file 											7d235ab
style: rename GenericProcessorFactory --> GenericServiceFactory. 	6a186a5
chore: fix NoEntityFrameworkExample project							354a1be

* chore: process feedback
* fix: DiscoveryTests project

* fix: NoEntityFrameworkExample project + tests
* refactor: simplify resource service constructor with IEnumerable<IQueryParameterService>
* feat: FirstOrDefault<TQueryParameterService>() extension method
* style: remove whitespace
* merge: merge into correct email:

* feat: upgrade to 2.2

* chore: spacing fix

* chore: revert silencing error

* chore: small spacing fix
* merge: merge into correct email:

* feat: upgrade to 2.2

* chore: spacing fix

* chore: revert silencing error

* chore: small spacing fix

* chore: remove unneeeded dependencies

* chore: fix framework dependencies

* chore: updates

* chore: test fixes

* chore: start integration tests

* chore: cleanup name of dertest

* chore: start of getRepostory

* chore: upgrade testsdk version + xunit version

* feat: use template in version control of packages in integrationTests

* feat: unit test assemblyinfo add, port old test to integration (attribute updater)

* docs: add version compatibility

* chore: add asterisk for version number

* feat: port defaultentityrepositorytests to integration tests

* chore: should add logging, done.

* tests: bad response from tests

* chore: fixes for lang version and making ifs more noticable

* fix: fix routing issue with upgrade to enableendpointrouting

* chore: HostEnvironment -> IWebHostEnvironment

* chore: act -> Act, assert -> Assert, arrange -> Arrange

* chore: fix tests

* chore: re-add unit test for defaultentityrepository for test IAsyncQueryProvider that's actually a List

* refactor: make if statements more conscise

* chore: final stretch

* tests: revert for good tests

* Revert "tests: revert for good tests"

This reverts commit 98b1119.

* Revert "chore: final stretch"

This reverts commit d6f763f.

* fix: client generated id tests

* fix: create data tests with workaround for efcore 3.0 bug

* refactor: DetachRelationships usage of is operator

* fix: move MetaStartup to other assembly as .net core 3 bug workaround

* fix: UpdatingRelationshipTests locally evaluated queries error

* feat: reintroduced generic processor (RepositoryRelationshipUpdateHelper) to fix locally evaluated expressions issue

* feat: full sql support for UpdateRelationshipsAsync using expression trees

* fix: DeletingDataTest

* fix: paging test

* fix: paging unit tests

* chore: remove RE-split models, duplicate models to NoEntityFrameworkExample

* fix: NoEntityFrameworkExample tests fixed by workaround assembly problem

* fix: connection string e2e test projects

* chore: minor cleanup

* chore: minor cleanup

* chore: cleanup
@maurei maurei closed this Oct 30, 2019
@maurei maurei deleted the fix/default-page-size branch October 30, 2019 16:32
@maurei maurei restored the fix/default-page-size branch October 30, 2019 16:33
@maurei maurei deleted the fix/default-page-size branch October 30, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants