Skip to content

task: make [Attr] and RequestDeserializer.SetAttributes open to extension #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

task: make [Attr] and RequestDeserializer.SetAttributes open to extension #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/JsonApiDotNetCore/Resources/Annotations/AttrAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace JsonApiDotNetCore.Resources.Annotations
/// Used to expose a property on a resource class as a JSON:API attribute (https://jsonapi.org/format/#document-resource-object-attributes).
/// </summary>
[AttributeUsage(AttributeTargets.Property)]
public sealed class AttrAttribute : ResourceFieldAttribute
public class AttrAttribute : ResourceFieldAttribute
{
private AttrCapabilities? _capabilities;

Expand Down
2 changes: 1 addition & 1 deletion src/JsonApiDotNetCore/Serialization/BaseDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ protected object DeserializeBody(string body)
/// <param name="resource">The parsed resource.</param>
/// <param name="attributeValues">Attributes and their values, as in the serialized content.</param>
/// <param name="attributes">Exposed attributes for <paramref name="resource"/>.</param>
protected IIdentifiable SetAttributes(IIdentifiable resource, IDictionary<string, object> attributeValues, IReadOnlyCollection<AttrAttribute> attributes)
protected virtual IIdentifiable SetAttributes(IIdentifiable resource, IDictionary<string, object> attributeValues, IReadOnlyCollection<AttrAttribute> attributes)
{
if (resource == null) throw new ArgumentNullException(nameof(resource));
if (attributes == null) throw new ArgumentNullException(nameof(attributes));
Expand Down