Coding guidelines tweaks

Build.ps1

@@ -19,7 +19,7 @@ function CheckLastExitCode {
 
 function RunInspectCode {
     $outputPath = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), 'jetbrains-inspectcode-results.xml')
-    dotnet jb inspectcode JsonApiDotNetCore.sln --output="$outputPath" --properties:Configuration=Release --severity=WARNING --verbosity=WARN -dsl=GlobalAll -dsl=SolutionPersonal -dsl=ProjectPersonal
+    dotnet jb inspectcode JsonApiDotNetCore.sln --output="$outputPath" --profile=JsonApiDotNetCore-WarningSeverities.DotSettings --properties:Configuration=Release --severity=WARNING --verbosity=WARN -dsl=GlobalAll -dsl=SolutionPersonal -dsl=ProjectPersonal
     CheckLastExitCode
 
     [xml]$xml = Get-Content "$outputPath"

CSharpGuidelinesAnalyzer.config

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<cSharpGuidelinesAnalyzerSettings>
+  <setting rule="AV1561" name="MaxParameterCount" value="6" />
+  <setting rule="AV1561" name="MaxConstructorParameterCount" value="12" />
+</cSharpGuidelinesAnalyzerSettings>

CodingGuidelines.ruleset

@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RuleSet Name="Coding Guidelines" Description=" " ToolsVersion="16.0">
+  <Rules AnalyzerId="CSharpGuidelinesAnalyzer" RuleNamespace="CSharpGuidelinesAnalyzer">
+    <Rule Id="AV1500" Action="None" />
+    <Rule Id="AV1505" Action="Warning" />
+    <Rule Id="AV1506" Action="Warning" />
+    <Rule Id="AV1507" Action="Warning" />
+    <Rule Id="AV1008" Action="Warning" />
+    <Rule Id="AV1130" Action="Warning" />
+    <Rule Id="AV1135" Action="Info" />
+    <Rule Id="AV1536" Action="None" />
+    <Rule Id="AV1537" Action="None" />
+    <Rule Id="AV1551" Action="Info" />
+    <Rule Id="AV1555" Action="Warning" />
+    <Rule Id="AV1564" Action="Info" />
+    <Rule Id="AV1568" Action="Warning" />
+    <Rule Id="AV1706" Action="Warning" />
+    <Rule Id="AV1710" Action="Info" />
+    <Rule Id="AV1711" Action="Info" />
+    <Rule Id="AV1738" Action="Warning" />
+    <Rule Id="AV1739" Action="Warning" />
+    <Rule Id="AV1745" Action="Warning" />
+    <Rule Id="AV1755" Action="Warning" />
+    <Rule Id="AV2210" Action="None" />
+    <Rule Id="AV2220" Action="Warning" />
+    <Rule Id="AV2230" Action="Info" />
+    <Rule Id="AV2305" Action="None" />
+    <Rule Id="AV2310" Action="Info" />
+    <Rule Id="AV2318" Action="Info" />
+  </Rules>
+</RuleSet>

Directory.Build.props

@@ -4,8 +4,15 @@
     <AspNetCoreVersion>3.1.*</AspNetCoreVersion>
     <EFCoreVersion>3.1.*</EFCoreVersion>
     <NpgsqlPostgreSQLVersion>3.1.*</NpgsqlPostgreSQLVersion>
+    <CodeAnalysisRuleSet>$(SolutionDir)CodingGuidelines.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
 
+  <ItemGroup>
+    <AdditionalFiles Include="$(SolutionDir)CSharpGuidelinesAnalyzer.config">
+      <Link>CSharpGuidelinesAnalyzer.config</Link>
+    </AdditionalFiles>
+  </ItemGroup>
+
   <PropertyGroup Condition="'$(Configuration)'=='Release'">
     <NoWarn>$(NoWarn);1591</NoWarn>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>

JsonApiDotNetCore.sln.DotSettings

@@ -72,6 +72,7 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$, $NAME$);</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=SpecifyStringComparison/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=StringEndsWithIsCultureSpecific/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=StringStartsWithIsCultureSpecific/@EntryIndexedValue">WARNING</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=SuggestDiscardDeclarationVarStyle/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=TailRecursiveCall/@EntryIndexedValue">SUGGESTION</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=TryCastAlwaysSucceeds/@EntryIndexedValue">WARNING</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnnecessaryWhitespace/@EntryIndexedValue">HINT</s:String>
@@ -554,7 +555,6 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$, $NAME$);</s:String>
 	<s:String x:Key="/Default/CodeStyle/CSharpVarKeywordUsage/ForBuiltInTypes/@EntryValue">UseExplicitType</s:String>
 	<s:String x:Key="/Default/CodeStyle/CSharpVarKeywordUsage/ForOtherTypes/@EntryValue">UseVarWhenEvident</s:String>
 	<s:String x:Key="/Default/CodeStyle/CSharpVarKeywordUsage/ForSimpleTypes/@EntryValue">UseVarWhenEvident</s:String>
-	<s:Boolean x:Key="/Default/CodeStyle/CSharpVarKeywordUsage/PreferExplicitDiscardDeclaration/@EntryValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/CSharpVarKeywordUsage/UseRoslynLogicForEvidentTypes/@EntryValue">False</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/EditorConfig/EnableClangFormatSupport/@EntryValue">False</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/EditorConfig/EnableEditorConfigSupport/@EntryValue">False</s:Boolean>
@@ -590,7 +590,7 @@ JsonApiDotNetCore.ArgumentGuard.NotNull($EXPR$, $NAME$);</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=546845333F49494AB6CF8F0477A0F71D/ReplacePattern/@EntryValue">JsonApiDotNetCore.ArgumentGuard.NotNull($argument$, nameof($argument$));&#xD;
 $left$ = $right$;</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=546845333F49494AB6CF8F0477A0F71D/SearchPattern/@EntryValue">$left$ = $right$ ?? throw new ArgumentNullException(nameof($argument$));</s:String>
-	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=546845333F49494AB6CF8F0477A0F71D/Severity/@EntryValue">SUGGESTION</s:String>
+	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=546845333F49494AB6CF8F0477A0F71D/Severity/@EntryValue">WARNING</s:String>
 	<s:Boolean x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/@KeyIndexDefined">True</s:Boolean>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/Comment/@EntryValue">Replace classic argument null check with Guard clause</s:String>
 	<s:Boolean x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/CustomPatternPlaceholder/=argument/@KeyIndexDefined">True</s:Boolean>
@@ -604,7 +604,7 @@ $left$ = $right$;</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/ReplaceComment/@EntryValue">Replace argument null check with Guard clause</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/ReplacePattern/@EntryValue">JsonApiDotNetCore.ArgumentGuard.NotNull($argument$, nameof($argument$));</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/SearchPattern/@EntryValue">if ($argument$ == null) throw new ArgumentNullException(nameof($argument$));</s:String>
-	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/Severity/@EntryValue">SUGGESTION</s:String>
+	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=67F8FFFFE7DCA24889232D6952BDFD59/Severity/@EntryValue">WARNING</s:String>
 	<s:Boolean x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/@KeyIndexDefined">True</s:Boolean>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/Comment/@EntryValue">Replace collection null/empty check with extension method</s:String>
 	<s:Boolean x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/CustomPatternPlaceholder/=collection/@KeyIndexDefined">True</s:Boolean>
@@ -617,7 +617,7 @@ $left$ = $right$;</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/ReplaceComment/@EntryValue">Replace collection null/empty check with extension method</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/ReplacePattern/@EntryValue">$collection$.IsNullOrEmpty()</s:String>
 	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/SearchPattern/@EntryValue">$collection$ == null || !$collection$.Any()</s:String>
-	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/Severity/@EntryValue">SUGGESTION</s:String>
+	<s:String x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=B3D9EE6B4EC62A4F961EB15F9ADEC2C6/Severity/@EntryValue">WARNING</s:String>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Assignee/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Injectables/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=linebreaks/@EntryIndexedValue">True</s:Boolean>

benchmarks/BenchmarkResourcePublicNames.cs

@@ -1,3 +1,5 @@
+#pragma warning disable AV1008 // Class should not be static
+
 namespace Benchmarks
 {
     internal static class BenchmarkResourcePublicNames

benchmarks/DependencyFactory.cs

@@ -3,9 +3,9 @@
 
 namespace Benchmarks
 {
-    internal static class DependencyFactory
+    internal sealed class DependencyFactory
     {
-        public static IResourceGraph CreateResourceGraph(IJsonApiOptions options)
+        public IResourceGraph CreateResourceGraph(IJsonApiOptions options)
         {
             var builder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);
             builder.Add<BenchmarkResource>(BenchmarkResourcePublicNames.Type);

benchmarks/Query/QueryParserBenchmarks.cs

@@ -20,6 +20,7 @@ namespace Benchmarks.Query
     [MemoryDiagnoser]
     public class QueryParserBenchmarks
     {
+        private readonly DependencyFactory _dependencyFactory = new DependencyFactory();
         private readonly FakeRequestQueryStringAccessor _queryStringAccessor = new FakeRequestQueryStringAccessor();
         private readonly QueryStringReader _queryStringReaderForSort;
         private readonly QueryStringReader _queryStringReaderForAll;
@@ -31,7 +32,7 @@ public QueryParserBenchmarks()
                 EnableLegacyFilterNotation = true
             };
 
-            IResourceGraph resourceGraph = DependencyFactory.CreateResourceGraph(options);
+            IResourceGraph resourceGraph = _dependencyFactory.CreateResourceGraph(options);
 
             var request = new JsonApiRequest
             {
@@ -107,7 +108,7 @@ public void ComplexQuery()
 
         private void Run(int iterations, Action action)
         {
-            for (int i = 0; i < iterations; i++)
+            for (int index = 0; index < iterations; index++)
             {
                 action();
             }

benchmarks/Serialization/JsonApiDeserializerBenchmarks.cs

@@ -29,12 +29,13 @@ public class JsonApiDeserializerBenchmarks
             }
         });
 
+        private readonly DependencyFactory _dependencyFactory = new DependencyFactory();
         private readonly IJsonApiDeserializer _jsonApiDeserializer;
 
         public JsonApiDeserializerBenchmarks()
         {
             var options = new JsonApiOptions();
-            IResourceGraph resourceGraph = DependencyFactory.CreateResourceGraph(options);
+            IResourceGraph resourceGraph = _dependencyFactory.CreateResourceGraph(options);
             var targetedFields = new TargetedFields();
             var request = new JsonApiRequest();
             var resourceFactory = new ResourceFactory(new ServiceContainer());

benchmarks/Serialization/JsonApiSerializerBenchmarks.cs

@@ -21,12 +21,13 @@ public class JsonApiSerializerBenchmarks
             Name = Guid.NewGuid().ToString()
         };
 
+        private readonly DependencyFactory _dependencyFactory = new DependencyFactory();
         private readonly IJsonApiSerializer _jsonApiSerializer;
 
         public JsonApiSerializerBenchmarks()
         {
             var options = new JsonApiOptions();
-            IResourceGraph resourceGraph = DependencyFactory.CreateResourceGraph(options);
+            IResourceGraph resourceGraph = _dependencyFactory.CreateResourceGraph(options);
             IFieldsToSerialize fieldsToSerialize = CreateFieldsToSerialize(resourceGraph);
 
             IMetaBuilder metaBuilder = new Mock<IMetaBuilder>().Object;

inspectcode.ps1

@@ -16,7 +16,7 @@ if ($LASTEXITCODE -ne 0) {
 
 $outputPath = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), 'jetbrains-inspectcode-results.xml')
 $resultPath = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), 'jetbrains-inspectcode-results.html')
-dotnet jb inspectcode JsonApiDotNetCore.sln --output="$outputPath" --properties:Configuration=Release --severity=WARNING --verbosity=WARN -dsl=GlobalAll -dsl=SolutionPersonal -dsl=ProjectPersonal
+dotnet jb inspectcode JsonApiDotNetCore.sln --output="$outputPath" --profile=JsonApiDotNetCore-WarningSeverities.DotSettings --properties:Configuration=Release --severity=WARNING --verbosity=WARN -dsl=GlobalAll -dsl=SolutionPersonal -dsl=ProjectPersonal
 
 if ($LASTEXITCODE -ne 0) {
     throw "Code inspection failed with exit code $LASTEXITCODE"

src/Examples/JsonApiDotNetCoreExample/Data/AppDbContext.cs

@@ -23,12 +23,12 @@ public AppDbContext(DbContextOptions<AppDbContext> options)
         protected override void OnModelCreating(ModelBuilder builder)
         {
             builder.Entity<TodoItem>()
-                .HasOne(t => t.Assignee)
-                .WithMany(p => p.AssignedTodoItems);
+                .HasOne(todoItem => todoItem.Assignee)
+                .WithMany(person => person.AssignedTodoItems);
 
             builder.Entity<TodoItem>()
-                .HasOne(t => t.Owner)
-                .WithMany(p => p.TodoItems);
+                .HasOne(todoItem => todoItem.Owner)
+                .WithMany(person => person.TodoItems);
 
             builder.Entity<ArticleTag>()
                 .HasKey(bc => new
@@ -45,23 +45,23 @@ protected override void OnModelCreating(ModelBuilder builder)
                 });
 
             builder.Entity<Person>()
-                .HasOne(t => t.StakeHolderTodoItem)
-                .WithMany(t => t.StakeHolders)
+                .HasOne(person => person.StakeHolderTodoItem)
+                .WithMany(todoItem => todoItem.StakeHolders)
                 .OnDelete(DeleteBehavior.Cascade);
 
             builder.Entity<TodoItem>()
-                .HasMany(t => t.ChildTodoItems)
-                .WithOne(t => t.ParentTodo);
+                .HasMany(todoItem => todoItem.ChildTodoItems)
+                .WithOne(todoItem => todoItem.ParentTodo);
 
             builder.Entity<Passport>()
-                .HasOne(p => p.Person)
-                .WithOne(p => p.Passport)
+                .HasOne(passport => passport.Person)
+                .WithOne(person => person.Passport)
                 .HasForeignKey<Person>("PassportKey")
                 .OnDelete(DeleteBehavior.SetNull);
 
             builder.Entity<TodoItem>()
-                .HasOne(p => p.OneToOnePerson)
-                .WithOne(p => p.OneToOneTodoItem)
+                .HasOne(todoItem => todoItem.OneToOnePerson)
+                .WithOne(person => person.OneToOneTodoItem)
                 .HasForeignKey<TodoItem>("OneToOnePersonKey");
         }
     }

src/Examples/JsonApiDotNetCoreExample/Definitions/ArticleHooksDefinition.cs

@@ -21,15 +21,15 @@ public ArticleHooksDefinition(IResourceGraph resourceGraph)
 
         public override IEnumerable<Article> OnReturn(HashSet<Article> resources, ResourcePipeline pipeline)
         {
-            if (pipeline == ResourcePipeline.GetSingle && resources.Any(r => r.Caption == "Classified"))
+            if (pipeline == ResourcePipeline.GetSingle && resources.Any(article => article.Caption == "Classified"))
             {
                 throw new JsonApiException(new Error(HttpStatusCode.Forbidden)
                 {
                     Title = "You are not allowed to see this article."
                 });
             }
 
-            return resources.Where(article => article.Caption != "This should not be included");
+            return resources.Where(article => article.Caption != "This should not be included").ToArray();
         }
     }
 }

src/Examples/JsonApiDotNetCoreExample/Definitions/PassportHooksDefinition.cs

@@ -31,12 +31,12 @@ public override void BeforeRead(ResourcePipeline pipeline, bool isIncluded = fal
 
         public override void BeforeImplicitUpdateRelationship(IRelationshipsDictionary<Passport> resourcesByRelationship, ResourcePipeline pipeline)
         {
-            resourcesByRelationship.GetByRelationship<Person>().ToList().ForEach(kvp => DisallowLocked(kvp.Value));
+            resourcesByRelationship.GetByRelationship<Person>().ToList().ForEach(pair => DisallowLocked(pair.Value));
         }
 
         public override IEnumerable<Passport> OnReturn(HashSet<Passport> resources, ResourcePipeline pipeline)
         {
-            return resources.Where(passport => !passport.IsLocked);
+            return resources.Where(passport => !passport.IsLocked).ToArray();
         }
     }
 }

src/Examples/JsonApiDotNetCoreExample/Definitions/PersonHooksDefinition.cs

@@ -24,7 +24,7 @@ public override IEnumerable<string> BeforeUpdateRelationship(HashSet<string> ids
 
         public override void BeforeImplicitUpdateRelationship(IRelationshipsDictionary<Person> resourcesByRelationship, ResourcePipeline pipeline)
         {
-            resourcesByRelationship.GetByRelationship<Passport>().ToList().ForEach(kvp => DisallowLocked(kvp.Value));
+            resourcesByRelationship.GetByRelationship<Passport>().ToList().ForEach(pair => DisallowLocked(pair.Value));
         }
     }
 }

src/Examples/JsonApiDotNetCoreExample/Definitions/TagHooksDefinition.cs

@@ -18,7 +18,7 @@ public TagHooksDefinition(IResourceGraph resourceGraph)
 
         public override IEnumerable<Tag> OnReturn(HashSet<Tag> resources, ResourcePipeline pipeline)
         {
-            return resources.Where(tag => tag.Name != "This should not be included");
+            return resources.Where(tag => tag.Name != "This should not be included").ToArray();
         }
     }
 }

src/Examples/JsonApiDotNetCoreExample/Definitions/TodoItemHooksDefinition.cs

@@ -31,13 +31,13 @@ public override void BeforeRead(ResourcePipeline pipeline, bool isIncluded = fal
 
         public override void BeforeImplicitUpdateRelationship(IRelationshipsDictionary<TodoItem> resourcesByRelationship, ResourcePipeline pipeline)
         {
-            List<TodoItem> todoItems = resourcesByRelationship.GetByRelationship<Person>().SelectMany(kvp => kvp.Value).ToList();
+            List<TodoItem> todoItems = resourcesByRelationship.GetByRelationship<Person>().SelectMany(pair => pair.Value).ToList();
             DisallowLocked(todoItems);
         }
 
         public override IEnumerable<TodoItem> OnReturn(HashSet<TodoItem> resources, ResourcePipeline pipeline)
         {
-            return resources.Where(todoItem => todoItem.Description != "This should not be included");
+            return resources.Where(todoItem => todoItem.Description != "This should not be included").ToArray();
         }
     }
 }

src/JsonApiDotNetCore/ArgumentGuard.cs

@@ -3,6 +3,8 @@
 using System.Linq;
 using JetBrains.Annotations;
 
+#pragma warning disable AV1008 // Class should not be static
+
 namespace JsonApiDotNetCore
 {
     internal static class ArgumentGuard
@@ -20,13 +22,26 @@ public static void NotNull<T>([CanBeNull] [NoEnumeration] T value, [NotNull] [In
 
         [AssertionMethod]
         [ContractAnnotation("value: null => halt")]
-        public static void NotNullNorEmpty<T>([CanBeNull] IEnumerable<T> value, [NotNull] [InvokerParameterName] string name)
+        public static void NotNullNorEmpty<T>([CanBeNull] IEnumerable<T> value, [NotNull] [InvokerParameterName] string name,
+            [CanBeNull] string collectionName = null)
         {
             NotNull(value, name);
 
             if (!value.Any())
             {
-                throw new ArgumentException("Collection cannot be empty.", name);
+                throw new ArgumentException($"Must have one or more {collectionName ?? name}.", name);
+            }
+        }
+
+        [AssertionMethod]
+        [ContractAnnotation("value: null => halt")]
+        public static void NotNullNorEmpty([CanBeNull] string value, [NotNull] [InvokerParameterName] string name)
+        {
+            NotNull(value, name);
+
+            if (value == string.Empty)
+            {
+                throw new ArgumentException("String cannot be null or empty.", name);
             }
         }
     }

src/JsonApiDotNetCore/ArrayFactory.cs

@@ -1,3 +1,6 @@
+#pragma warning disable AV1008 // Class should not be static
+#pragma warning disable AV1130 // Return type in method signature should be a collection interface instead of a concrete type
+
 namespace JsonApiDotNetCore
 {
     internal static class ArrayFactory