Fixed parsing of incoming comma-separated list of Accept headers #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our integration tests did actually test for compound values. But they use an internal loopback, which bypasses the actual Accept header parsing that occurs on incoming socket bytes.
Because
httpContext.Request.Headers["Accept"]returnsStringValues, I blindly assumed that this would break up comma-separated values. But it does not, as explained here. It only contains multiple entries when multiple Accept header lines are sent sequentially (or when short-circuited, as in our tests).There seems no way to bypass the internal comma-separated values parsing that occurs in integration tests. Even passing a single comma-delimited string runs through an internal parser, producing a
StringValueswith multiple entries.Fixes #970.