Fix spec: should generate default form def from a schema #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fieldset defaults will include the key attributed (commit 730ca35)
|
@jozefizso thanks for the PRs, have you taken a look at the webpack/babel branch? Combined with the json-schema-core repo that is the 1.x.x version of the library, I have made a lot of fixes in that already and it could always do with some more people testing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
keyattribute to fieldsets in a default form. This attribute was added in PR #578Fixes Related issues
Checklist
@json-schema-form/angular-schema-form-lead