-
Notifications
You must be signed in to change notification settings - Fork 647
port condition loop from development branch for IE fix #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port condition loop from development branch for IE fix #906
Conversation
src/services/builder.js
Outdated
: evalExpr | ||
); | ||
|
||
if (child.hasAttribute && child.hasAttribute('ng-if')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For IE11, the hasAttribute check is needed
All set, created new PR with just the code change. |
Added reset of ngif var to false
@Anthropic thank you! If there is any chance to get a 0.8.14 bower module pushed up at some point that would be fantastic. Much appreciated all your effort on this. |
@Deklin if you are willing to do some testing on it for me then I am, the reason it hasn't come sooner is that the 1.0.0 branch is where the unit tests are fixed and working, without tests on 0.x (which I didn't work on much) I'm terrified of releasing a "patch" that breaks anything. If I make a build on the branch would you be willing to test it for me? |
Oh and I don't mean all the pressure will be on you ;) |
I'd be happy to, the patch I created a PR for that you merged, I can say has been well tested. If that is the only difference in whats in that support branch that is good news. |
@Deklin great to hear, I really should try to get the tests working on that branch, but unfortunately I am time short and I am hoping that 99.9% of people will migrate to 1.0.0 when it hits beta. |
Description
Fix for IE support of the builder.condition. Ported from your 1.0 branch.
Fixes Related issues
Checklist
@json-schema-form/angular-schema-form-lead
Comments
The test cases we have were internal to the product we are using, but since this was ported from your 1.0 branch I would assume this is good as well.