Skip to content

port condition loop from development branch for IE fix #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2017

Conversation

Deklin
Copy link

@Deklin Deklin commented Jun 21, 2017

Description

Fix for IE support of the builder.condition. Ported from your 1.0 branch.

Fixes Related issues

Checklist

  • I have read and understand the CONTRIBUTIONS.md file
  • I have searched for and linked related issues
  • I have created test cases to ensure quick resolution of the PR is easier
  • I am NOT targeting main branch
  • I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

Comments

The test cases we have were internal to the product we are using, but since this was ported from your 1.0 branch I would assume this is good as well.

: evalExpr
);

if (child.hasAttribute && child.hasAttribute('ng-if')) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For IE11, the hasAttribute check is needed

@Deklin
Copy link
Author

Deklin commented Jun 21, 2017

All set, created new PR with just the code change.

Added reset of ngif var to false
@Anthropic Anthropic merged commit e4b53ce into json-schema-form:support/0.x Jun 24, 2017
@Deklin
Copy link
Author

Deklin commented Jun 26, 2017

@Anthropic thank you! If there is any chance to get a 0.8.14 bower module pushed up at some point that would be fantastic. Much appreciated all your effort on this.

@Anthropic
Copy link
Member

@Deklin if you are willing to do some testing on it for me then I am, the reason it hasn't come sooner is that the 1.0.0 branch is where the unit tests are fixed and working, without tests on 0.x (which I didn't work on much) I'm terrified of releasing a "patch" that breaks anything. If I make a build on the branch would you be willing to test it for me?

@Anthropic
Copy link
Member

Oh and I don't mean all the pressure will be on you ;)
I will ask others also, just want to know if you have capacity to help!

@Deklin
Copy link
Author

Deklin commented Jun 27, 2017

I'd be happy to, the patch I created a PR for that you merged, I can say has been well tested. If that is the only difference in whats in that support branch that is good news.

@Anthropic
Copy link
Member

@Deklin great to hear, I really should try to get the tests working on that branch, but unfortunately I am time short and I am hoping that 99.9% of people will migrate to 1.0.0 when it hits beta.

@rhelgeby rhelgeby mentioned this pull request Feb 19, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants