Flip protocol-relative URI Reference (not a URI) #156
Conversation
|
@epoberezkin I can see how draft-03 makes things a little ambiguous, but draft-fge-json-schema-validation-00 specifically says
I don't think we should be adding any new tests to the expired suites, but certainly we can fix broken ones. In all three files, that schema-test tests two URI References, one is valid and one is invalid. Well it has to be one or the other... |
|
@awwright got it, no problem, just wanted to clarify.
I actually though it could be good to add a couple of tests to draft 4 - there are plenty of badly supported cases... The motivation for it is that you can diff between 4 and 6 folders and see that it is not a change a spec but just an additional test to both the latest and previous spec version. What do you think? |
|
@epoberezkin The I-D still isn't out yet, get it in quick? hehe In any event, it's just my opinion. |
|
@Julian Anything left to merge this? |
|
@awwright nope already reviewed :) |
|
I was about to merge, but can I request you change the commit message to reference the issue and this PR please? That way, if anyone sees the change, looks it up on github, and wants a place of reference to understand why the change happened, and that they can challenge it / raise an issue with it, then it would make doing so far easier. Make sense? |
|
@Relequestual @Julian can do that in the merge message. Actually, that should be the default behavior. |
Plenty of confusion still about Draft 3/4's URI, but that's already being addressed in Draft 6. After this PR, the tests here are at least internally consistent (at this point they all consider only URIs not URI references). Refs: #58, #77, #156 * awwright/master: Flip protocol-relative URI Reference (not a URI)
Affected test was added in #87