Reject single '.' character for hostname formats #759
Conversation
A single dot is not allowed under RFC 1123.
sirosen
force-pushed
the
hostname-format-reject-single-dot
branch
from
f1beee8 to
4a3efd1
Compare
|
I've seen this of course, but won't look carefully at it until resolving some breaking changes I have to deal with as part of updating the test suite in my implementation (coming from PRs here which moved remotes around and which break me running the test suite in the Python package), so that's going to be a bit higher priority for me to fix with the limited time I have at the moment, but I'll try to have a look after that, as of course this seems notionally right! Obviously someone else might merge in the interim if it looks right to them (and thanks as usual of course!). |
|
I'm just trying to clean up from my accidental push to This was one of the two tests I introduced over there. But no pressure of course! |
|
I removed it as part of the merge (so we're back to good I think in terms of being able to merge future changes, namely this PR after being merged here), though I haven't pushed yet because of those aforementioned issues :/ which are completely unrelated to you obviously. I hope later today to give it another shot. |
|
OK, now that I've done that downstream -- yeah thanks this looks good to me as well -- for any future reference, at least one part of RFC 1123 that clearly indicates this isn't allowed is:
|
Based on json-schema-org/JSON-Schema-Test-Suite#759 it is not allowed to have a single dot in the hostname (and IDN hostname). The hostname validator already had the correct behavior but the IDN hostname validator did not
This is a follow-up from #758.
Add negative tests for "." for hostname formats, based on RFC 1123 not allowing this value.