Skip to content

Add initial infrastructure document #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Relequestual
Copy link
Member

@Relequestual Relequestual commented Apr 22, 2022

Resolves #167

I'm sure I had some more things in mind, but I can't think of anything else now. maybe it was all covered.

Thoughts welcome!

@Relequestual Relequestual marked this pull request as ready for review May 26, 2022 15:55
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason every sentence is on a new line? Combining some of these into related paragraphs might help it read better.

@Julian
Copy link
Member

Julian commented May 27, 2022

Is there a reason every sentence is on a new line? Combining some of these into related paragraphs might help it read better.

Doing so is "somewhat" common style for markdown, see e.g. here. It makes for nice diffs.

@Julian
Copy link
Member

Julian commented May 27, 2022

Ah sorry, in the rendered doc though, I agree paragraphs would be nicer, which is probably where you were referencing, so my comment is nonsense, apologies!

Copy link
Member

@Julian Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor copyediting things.

More importantly -- I feel like the literal most important piece of infrastructure we run is hosted metaschemas for all drafts -- perhaps so important we should explicitly call those out as being hosted on GH pages via the spec repo?

Relequestual and others added 3 commits May 27, 2022 14:40
Co-authored-by: Greg Dennis <[email protected]>
Co-authored-by: Julian Berman <[email protected]>
@Relequestual
Copy link
Member Author

Does Zapier support some form of automated configuration (say a repository of terraform files configuring which processes to configure)? If it did that'd maybe mitigate this risk by letting us have a repo somewhere we could apply to a new account if we ever did need to move it. - @Julian - (Copying this out from a review comment so it isn't lost if outdated)

We can export individual "Zaps", which gives us a JSON file, which can be imported if required.

The Zap for GitHub Discussions might be able to go away at some point.
I'm working on another for preventing channel topic changes.

You can trigger GitHub Actions from a webhook, however you also need that request to provide your access token, so we would need to proxy the caller to add the header anyway. Could do that pretty easily with Cloudflare Workers. The more I think about it, this could be a better solution for something I was looking into.

It would be easy to migrate our Zaps to GitHub Actions, but would take a little effort.
We should consider doing this work.

@Julian
Copy link
Member

Julian commented Jun 17, 2022

Made the changes I was suggesting above, so hitting the merge button since this seems like a great start to me at this point, and can be added to if we forgot anything. Obviously speak up if anyone has more.

@Julian Julian merged commit 27ece13 into json-schema-org:main Jun 17, 2022
@Relequestual Relequestual deleted the 167-identify-and-document-other-core-project-infrastructure branch July 11, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify and document other core project infrastructure
4 participants