-
-
Notifications
You must be signed in to change notification settings - Fork 52
Add initial infrastructure document #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial infrastructure document #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason every sentence is on a new line? Combining some of these into related paragraphs might help it read better.
Doing so is "somewhat" common style for markdown, see e.g. here. It makes for nice diffs. |
Ah sorry, in the rendered doc though, I agree paragraphs would be nicer, which is probably where you were referencing, so my comment is nonsense, apologies! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor copyediting things.
More importantly -- I feel like the literal most important piece of infrastructure we run is hosted metaschemas for all drafts -- perhaps so important we should explicitly call those out as being hosted on GH pages via the spec repo?
Co-authored-by: Greg Dennis <[email protected]>
Co-authored-by: Julian Berman <[email protected]>
Co-authored-by: Julian Berman <[email protected]>
We can export individual "Zaps", which gives us a JSON file, which can be imported if required. The Zap for GitHub Discussions might be able to go away at some point. You can trigger GitHub Actions from a webhook, however you also need that request to provide your access token, so we would need to proxy the caller to add the header anyway. Could do that pretty easily with Cloudflare Workers. The more I think about it, this could be a better solution for something I was looking into. It would be easy to migrate our Zaps to GitHub Actions, but would take a little effort. |
Made the changes I was suggesting above, so hitting the merge button since this seems like a great start to me at this point, and can be added to if we forgot anything. Obviously speak up if anyone has more. |
Resolves #167
I'm sure I had some more things in mind, but I can't think of anything else now. maybe it was all covered.
Thoughts welcome!