Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Use HTTPS for external URLs where applicable #217

Merged

Conversation

oboukli
Copy link
Contributor

@oboukli oboukli commented Jun 8, 2018

No description provided.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

The URLs without a path component all redirect to remove the trailing "/" so I'd prefer not to have it on those URLs. It's fine on the others.

Other than that two very minor nitpicks- if you'd prefer not to update the PR I can change them while merging it, but I prefer to let people reply rather than just dong that.

- [JSONForms (jsonforms.io)](http://jsonforms.io) (EclipseSource) (MIT)
- [Jsonary](http://jsonary.com/) (MIT)
- [JSONForms (jsonforms.io)](https://jsonforms.io/) (EclipseSource) (MIT)
- [Jsonary](https://github.com/jsonary-js/) (MIT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be https://github.com/jsonary-js/jsonary, not sure why the redirect of the old site went where it did.

@@ -47,7 +47,7 @@ _If you are accessing the above meta-schema links **from a web browser**, you wi
Migrating from older drafts
-------------

The release notes discuss the changes impacting users and implementors:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both spellings are correct, and I'm sure we use "implementors" elsewhere so I'd prefer not to change it.

@handrews
Copy link
Contributor

Hmm... looks like we're already inconsistent on trailing slashes so I'll just merge as-is and sort it out later.

@handrews handrews merged commit b18feec into json-schema-org:master Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants