Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Convert other html pages to Markdown #85

Merged
merged 5 commits into from
May 8, 2017

Conversation

adamvoss
Copy link
Contributor

I was bored the other day so converted the rest of the HTML pages to Markdown. Unlike #84 where I wanted header anchors, there is no reason for these changes other than the format conversion.

Only changes I observed:

  • The Markdown rendering uses smart quotes. Most noticeable is the apostrophe is rendered instead of '. This could be configured if there is a desire to not have smart quotes.

  • on example2, there is non-semantic vertical whitespace (a gap) after

    "The full entry schema
    The resulting schema is quite large:"

    but before the code sample in the current version. I did not preserve that gap because I couldn't see any reason for it (the other sections do not have that amount of gap)

Pandoc again deserves most of the credit. The commits have also been pushed to may master branch which can be viewed at https://vossad01.github.io/json-schema-org.github.io/

@adamvoss adamvoss force-pushed the master branch 2 times, most recently from 8a9d7b6 to 2d76324 Compare March 24, 2017 02:24
@Relequestual Relequestual self-requested a review March 24, 2017 09:08
@Relequestual
Copy link
Member

I was thinking about asking if you wanted to do this, but hey you've done it anyway! =D
Again, I'll probably need to wait to review this properly =]

Super thanks!

This way they work from both GitHub and the website.
@@ -1,3 +1,5 @@
// This file is unmodified but must be included so our custom syntax-highlighting partial is read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says the file is unmodified but there are actually two small changes. Was that intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot, I didn't realize I opened this file PR against my master branch. I meant it to be my markdownify branch. That change should not even be here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how that comment does not make sense. The comment means to say it is unmodified relative to the minima theme (the two modifications you see are reverting local change, that were instead moved into main.scss

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@handrews I can't change what branch this is open against. Instead of closing and opening a new PR, I just pushed my markdownify branch to my master. I fixed this wording issue in my bundle branch, which is for PR #86.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vossad01 thanks! @Relequestual or I will follow up.

@adamvoss adamvoss mentioned this pull request Apr 13, 2017
@Relequestual Relequestual self-assigned this Apr 18, 2017
@Relequestual
Copy link
Member

I've got training for the rest of this week. Hopefull I can review this change after that! I want to make sure this PR doesn't change any content by visual inspection.

@handrews handrews merged commit d69fb9d into json-schema-org:master May 8, 2017
@Relequestual
Copy link
Member

Relequestual commented Jun 28, 2017

Apologisies for being a terrible human =[

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants