-
-
Notifications
You must be signed in to change notification settings - Fork 213
Conversation
8a9d7b6
to
2d76324
Compare
I was thinking about asking if you wanted to do this, but hey you've done it anyway! =D Super thanks! |
This way they work from both GitHub and the website.
_sass/minima.scss
Outdated
@@ -1,3 +1,5 @@ | |||
// This file is unmodified but must be included so our custom syntax-highlighting partial is read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says the file is unmodified but there are actually two small changes. Was that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, I didn't realize I opened this file PR against my master
branch. I meant it to be my markdownify
branch. That change should not even be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how that comment does not make sense. The comment means to say it is unmodified relative to the minima
theme (the two modifications you see are reverting local change, that were instead moved into main.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vossad01 thanks! @Relequestual or I will follow up.
I've got training for the rest of this week. Hopefull I can review this change after that! I want to make sure this PR doesn't change any content by visual inspection. |
Apologisies for being a terrible human =[ |
I was bored the other day so converted the rest of the HTML pages to Markdown. Unlike #84 where I wanted header anchors, there is no reason for these changes other than the format conversion.
Only changes I observed:
The Markdown rendering uses smart quotes. Most noticeable is the apostrophe is rendered
’
instead of'
. This could be configured if there is a desire to not have smart quotes.on example2, there is non-semantic vertical whitespace (a gap) after
but before the code sample in the current version. I did not preserve that gap because I couldn't see any reason for it (the other sections do not have that amount of gap)
Pandoc again deserves most of the credit. The commits have also been pushed to may
master
branch which can be viewed at https://vossad01.github.io/json-schema-org.github.io/