-
-
Notifications
You must be signed in to change notification settings - Fork 313
Clarify: all applicators collect annotations, including "contains" #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
All annotations? What about Otherwise I think this is a good idea. |
@gregsdennis annotations are still dropped whenever validation fails (and it's impossible to evaluate |
@gregsdennis ok apparently I'm a lying lier who lies because I'm 99% sure that is because we didn't have any sort of output format when I first wrote the spec for that keyword, and it wasn't clear how to make use of them if they were collected. That is no longer the case, so I'm writing the PR to change it to collect annotations and be a "normal" applicator. We can debate whether that is the right option on the PR 😄 |
clerical error? This issue is in milestone draft-09, but the PR that closed it is in milestone draft-08 (which maybe should be subtitled |
As noted in #766, we need to emphasize how applicators and annotation collection works, in particular that an applicator like
contains
does collect annotations, which means that when annotation collection is enabled, you cannot short-circuit the evaluation. I think we note this withanyOf
but notcontains
. Those are the only two applicators that combine validation results with OR and could therefore be short-circuited when not collecting annotations.The text was updated successfully, but these errors were encountered: