Clarify annotation collection with applicators #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, "contains" collects annotations. I'm not sure where the exception came from, as it was not present in the previous draft (to the extent that that draft mentioned annotations). The CREF actually did talk about annotation collection so apparently this was a bit of a muddled mess anyway. This makes "contains" behave like all other applicators, producing both assertion and annotation results.
handrews
requested review from
Julian,
Relequestual,
gregsdennis and
johandorland
gregsdennis
reviewed
Jul 26, 2019
gregsdennis
reviewed
Jul 26, 2019
You have to look at all subschemas in the cases in question, which may or may not result in actual collection of annotations, depending on the assertion outcomes of the individual subschemas.
|
@gregsdennis I did an update a while back for one of your comments, does it look OK now? I'd like to merge this if so. |
gregsdennis
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #768. No release notes because the part about "contains"
not collecting annotations was never in the release notes, and
it wasn't in the previous draft either.
In particular, "contains" collects annotations. I'm not sure
where the exception came from, as it was not present in the
previous draft (to the extent that that draft mentioned
annotations).
The CREF actually did talk about annotation collection so
apparently this was a bit of a muddled mess anyway.
This makes "contains" behave like all other applicators,
producing both assertion and annotation results.